Skip to content

#950: avoid non-interactive GPG handling for Rancher Desktop on SUSE - #2413

Open
cap-juan wants to merge 1 commit into
devonfw:mainfrom
cap-juan:feature/950-avoid-no-gpg-checks-docker
Open

#950: avoid non-interactive GPG handling for Rancher Desktop on SUSE#2413
cap-juan wants to merge 1 commit into
devonfw:mainfrom
cap-juan:feature/950-avoid-no-gpg-checks-docker

Conversation

@cap-juan

@cap-juan cap-juan commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #950

Implemented changes:

  • Removed --no-gpg-checks from the Rancher Desktop installation on SUSE Linux.
  • Added support for interactive native package installation.
  • Configured Rancher Desktop to use interactive zypper install so users can explicitly reject, temporarily trust, or permanently trust the repository signing key.
  • Kept the existing non-interactive Zypper behavior unchanged for other native packages.

Testing instructions

Please add concise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Start a SUSE Linux environment where the Rancher repository signing key is not already trusted.

  2. Run: ide install docker

  3. Verify that the generated Rancher Desktop installation command does not contain: --no-gpg-checks or --non-interactive

  4. Verify that Zypper asks how the repository signing key should be handled and allows the user to choose between rejecting, temporarily trusting, or permanently trusting the key.

  5. Verify that other Zypper-based native package installations remain non-interactive.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summaries what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Sep 3, 2026
@cap-juan cap-juan moved this from 🆕 New to Team Review in IDEasy board Sep 3, 2026
@cap-juan cap-juan added enhancement New feature or request docker docker and esp. DockerDesktop linux specific for linux OS (debian, ubunutu, suse, etc.) labels Sep 3, 2026
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 33758527195

Coverage increased (+0.03%) to 73.826%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 12 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

12 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/docker/Docker.java 8 54.79%
com/devonfw/tools/ide/tool/NativePackageManager.java 3 72.48%
com/devonfw/tools/ide/tool/NativePackage.java 1 96.43%

Coverage Stats

Coverage Status
Relevant Lines: 18590
Covered Lines: 14342
Line Coverage: 77.15%
Relevant Branches: 8280
Covered Branches: 5495
Branch Coverage: 66.36%
Branches in Coverage %: Yes
Coverage Strength: 3.29 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker docker and esp. DockerDesktop enhancement New feature or request linux specific for linux OS (debian, ubunutu, suse, etc.)

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

avoid --no-gpg-checks for docker installation on SUSE Linux

2 participants