#693: Setup file not working on Mac

[blizzarac]

Tested on mac

1. ide alias is not working like this -> Changing alias from source to ide to directly to ide
2. IDE_URL was missing -> Added for current folder

[CLAassistant]

All committers have signed the CLA.

[coveralls]

Pull Request Test Coverage Report for Build 11539868974

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 66.774%

---

Totals
Change from base Build 11527033206:	0.02%
Covered Lines:	6267
Relevant Lines:	9038

---

💛 - Coveralls

[hohwille]

@blizzarac thanks for testing IDEasy (in beta phase already) and trying to help by creating a PR 👍
Could you please first describe the error you were experiencing on MacOS?
It is definitely wrong to remove the source statement from the script.
I can explain that in detail why we need to source the script (see also #63) but first I would like to understand what was going wrong.

IDE_URL was missing -> Added for current folder

I guess you mean IDE_ROOT.
That is definitely a known issue for Linux and Mac you we were already thinking about fixing this in the way you did.
However, currently we have a OS specific solution for that on Windows setting this in the Windows System Environment Variables after calling the setup Bash script (see https://github.com/devonfw/IDEasy/blob/main/cli/src/main/package/setup.bat). Therefore we should add an OS check and avoid doing that on Windows.

if [ "${OSTYPE}" = "cygwin" ] || [ "${OSTYPE}" = "msys" ]; then
...
else
...
fi

Do you want to do that and update your PR? Otherwise, we are happy to take over your work and create a new PR fixing that and hopefully include that into the planned 2024.10.001-beta release.

[hohwille]

See also #423

[hohwille]

@blizzarac as you seem to be quite busy with other stuff, I would suggest the following:

• we create another PR for adding IDE_ROOT during setup for Linux and MacOS.
• you only need to provide a small explanation of the error that you were facing that lead you to removing the source instruction. If there is some other "bug" than the missing IDE_ROOT, we can fix that. A comment would even be sufficient if you have no time. Otherwise creating a new bug would be even better.

[blizzarac]

@hohwille sorry about, was a busy week. I think the problems that I had, had to do with my chaotic setup before I talked to @jan-vcapgemini and found out that I had to put everything in a _ide folder. Maybe this is the bug here (this was missing in the documentation)

[blizzarac]

I have pushed a new version removing the source parts and added the IDE_ROOT with OS guards, hope that works for you

[hohwille]

@blizzarac thank you so much for the update of your PR. This is now perfect and ready for merge 👍