This is more of a small nit I noticed while working on #18, some of the product config structs don't share the same naming, or generally lack consistency:
For example, in Vault and Bounary, there's a Key:
|
Key string `json:"key,omitempty" mapstructure:"key"` |
|
Key string `json:"key,omitempty" mapstructure:"key"` |
But, for Nomad and Consul there's a NomadKey and ConsulKey:
|
NomadKey string `json:"key,omitempty" mapstructure:"key"` |
|
ConsulKey string `json:"key,omitempty" mapstructure:"key"` |
Or, in Bounary there's TlsInsecure (better name):
|
TlsInsecure string `json:"tls_insecure,omitempty" mapstructure:"tls_insecure"` |
But, In Vault there's a SkipVerify (doing the same thing, with a different, and less ideal name):
|
SkipVerify string `json:"skip_verify,omitempty" mapstructure:"skip_verify"` |
Then there's the issue that Consul and Nomad have no equivalent exposed here, and that it would probably make sense for these to be booleans instead of string values.
This is more of a small nit I noticed while working on #18, some of the product config structs don't share the same naming, or generally lack consistency:
For example, in
VaultandBounary, there's aKey:target-cli/cmd/root.go
Line 64 in 7a10f70
target-cli/cmd/root.go
Line 41 in 7a10f70
But, for
NomadandConsulthere's aNomadKeyandConsulKey:target-cli/cmd/root.go
Line 107 in 7a10f70
target-cli/cmd/root.go
Line 95 in 7a10f70
Or, in
Bounarythere'sTlsInsecure(better name):target-cli/cmd/root.go
Line 42 in 7a10f70
But, In
Vaultthere's aSkipVerify(doing the same thing, with a different, and less ideal name):target-cli/cmd/root.go
Line 67 in 7a10f70
Then there's the issue that Consul and Nomad have no equivalent exposed here, and that it would probably make sense for these to be booleans instead of string values.