Prefer https for github and twitter#594
Conversation
This is a little nitpicky, but both GitHub and Twitter are served on `https`. Linking to the `http` version causes a redirect.
|
Fixes #595 |
|
Damn. I would have thought I would have caught this :) |
|
😀 |
|
@adrianmoisey in the future, can you add closing keywords to your initial PR comment? That way when we merge the PR the issue connected gets closed (like see how Bridget did it?) |
|
Sure, no worries. |
Nope! But you can edit the description of the PR. Basically, I just noticed that it didn't auto-close when we merged it, and I see that it was because @bridgetkromhout put the closing keywords in a later comment, which I think she thought would auto-close it. On the theme, we like there to be a matching issue because the changelog is driven by closed issues, not by closed PRs :) |
This is a little nitpicky, but both GitHub and Twitter are served on
https.Linking to the
httpversion causes a redirect.This change is