Skip to content
This repository was archived by the owner on Jul 21, 2019. It is now read-only.

Prefer https for github and twitter#594

Merged
bridgetkromhout merged 1 commit intodevopsdays:masterfrom
adrianmoisey:patch-1
Sep 1, 2017
Merged

Prefer https for github and twitter#594
bridgetkromhout merged 1 commit intodevopsdays:masterfrom
adrianmoisey:patch-1

Conversation

@adrianmoisey
Copy link
Member

@adrianmoisey adrianmoisey commented Sep 1, 2017

This is a little nitpicky, but both GitHub and Twitter are served on https.
Linking to the http version causes a redirect.


This change is Reviewable

This is a little nitpicky, but both GitHub and Twitter are served on `https`.
Linking to the `http` version causes a redirect.
@bridgetkromhout
Copy link
Contributor

Fixes #595

@bridgetkromhout bridgetkromhout merged commit 103e278 into devopsdays:master Sep 1, 2017
@ghost ghost removed the needs-review label Sep 1, 2017
@adrianmoisey adrianmoisey deleted the patch-1 branch September 1, 2017 15:32
@mattstratton
Copy link
Member

Damn. I would have thought I would have caught this :)

@adrianmoisey
Copy link
Member Author

😀

@mattstratton
Copy link
Member

@adrianmoisey in the future, can you add closing keywords to your initial PR comment? That way when we merge the PR the issue connected gets closed (like see how Bridget did it?)

@adrianmoisey
Copy link
Member Author

Sure, no worries.
I did make the PR before the issue was created.
Do you require issues be created before they are solved?

@mattstratton
Copy link
Member

Do you require issues be created before they are solved?

Nope! But you can edit the description of the PR. Basically, I just noticed that it didn't auto-close when we merged it, and I see that it was because @bridgetkromhout put the closing keywords in a later comment, which I think she thought would auto-close it.

On the theme, we like there to be a matching issue because the changelog is driven by closed issues, not by closed PRs :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants