This repository was archived by the owner on Jul 21, 2019. It is now read-only.
Allow event_link to also pull event data#617
Merged
mattstratton merged 2 commits intodevopsdays:masterfrom Feb 8, 2018
Merged
Conversation
Member
|
Interesting! Can you do me a favor and open an issue that will connect to this PR, explaining it? The reason is that our changelog generator is driven by closed issues, and I want to make sure that this gets credit if we merge it! |
Member
|
@tylermauthe - two things:
|
Contributor
Author
|
Sorry for the delay - I've created #623 and added the example as requested 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to extend the event_link shortcode to optionally pull from the event data - so that I can pull
cfp_linkandregistration_linkfrom my data file and link to them.This PR adds two new properties to the shortcode, while preserving existing behaviour:
url-key- specifies a key whose value will be bond to thehrefof the linktext-key- specifies a key whose value will be bound to the text node of the linkIf both
url-keyandpageare specified,url-keywill be preferred. Similarly,text-keywill be preferred overtext.This change is