Skip to content
This repository was archived by the owner on Jul 21, 2019. It is now read-only.

Allow event_link to also pull event data#617

Merged
mattstratton merged 2 commits intodevopsdays:masterfrom
terraboops:event-link-data-source
Feb 8, 2018
Merged

Allow event_link to also pull event data#617
mattstratton merged 2 commits intodevopsdays:masterfrom
terraboops:event-link-data-source

Conversation

@terraboops
Copy link
Copy Markdown
Contributor

@terraboops terraboops commented Jan 4, 2018

I'd like to extend the event_link shortcode to optionally pull from the event data - so that I can pull cfp_link and registration_link from my data file and link to them.

This PR adds two new properties to the shortcode, while preserving existing behaviour:
url-key - specifies a key whose value will be bond to the href of the link
text-key - specifies a key whose value will be bound to the text node of the link

If both url-key and page are specified, url-key will be preferred. Similarly, text-key will be preferred over text.


This change is Reviewable

@mattstratton
Copy link
Copy Markdown
Member

Interesting! Can you do me a favor and open an issue that will connect to this PR, explaining it? The reason is that our changelog generator is driven by closed issues, and I want to make sure that this gets credit if we merge it!

@mattstratton
Copy link
Copy Markdown
Member

@tylermauthe - two things:

  1. can you open an issue in this repo as I mentioned above so we can link this as a new feature?
  2. Can you put an example into 2017-ponyville so we have a test?

@terraboops
Copy link
Copy Markdown
Contributor Author

Sorry for the delay - I've created #623 and added the example as requested 🙌

@mattstratton mattstratton merged commit c8d1514 into devopsdays:master Feb 8, 2018
@terraboops terraboops deleted the event-link-data-source branch April 7, 2018 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants