Skip to content

fix(quality): preserve capped reader failures to prevent uncapped reads in diff scans #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxxjohn merged 1 commit into from
Aug 18, 2026
Merged

fix(quality): preserve capped reader failures to prevent uncapped reads in diff scans #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions internal/codeguard/checks/quality/quality_precision_delta.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,8 @@ func changedFilesForTarget(env support.Context, target core.TargetConfig) []stri

func readCurrentTargetFile(env support.Context, target core.TargetConfig, rel string) ([]byte, bool) {
if env.ReadTargetFile != nil {
if data, err := env.ReadTargetFile(target, rel); err == nil {
return data, true
}
data, err := env.ReadTargetFile(target, rel)
return data, err == nil
}
data, err := os.ReadFile(filepath.Join(target.Path, filepath.FromSlash(rel))) //nolint:gosec // rel comes from the scan's own changed-file list
return data, err == nil
Expand Down
28 changes: 28 additions & 0 deletions internal/codeguard/checks/quality/quality_precision_delta_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
package quality

import (
"errors"
"os"
"path/filepath"
"testing"

"github.com/devr-tools/codeguard/internal/codeguard/checks/support"
"github.com/devr-tools/codeguard/internal/codeguard/core"
)

func TestReadCurrentTargetFileDoesNotBypassConfiguredReaderError(t *testing.T) {
target := core.TargetConfig{Path: t.TempDir()}
if err := os.WriteFile(filepath.Join(target.Path, "oversized.go"), []byte("package sample"), 0o600); err != nil {
t.Fatalf("write current target file: %v", err)
}
env := support.Context{
ReadTargetFile: func(core.TargetConfig, string) ([]byte, error) {
return nil, errors.New("file exceeds scan limit")
},
}

data, ok := readCurrentTargetFile(env, target, "oversized.go")
if ok || data != nil {
t.Fatalf("readCurrentTargetFile() = (%q, %t), want (nil, false)", data, ok)
}
}
Loading