Skip to content

fix: reduce retries for ERRCONNABORTED error when uploading attachments#222

Merged
gasperzgonec merged 1 commit into
mainfrom
gasperz/ASCPT-44
Jul 16, 2026
Merged

fix: reduce retries for ERRCONNABORTED error when uploading attachments#222
gasperzgonec merged 1 commit into
mainfrom
gasperz/ASCPT-44

Conversation

@gasperzgonec

Copy link
Copy Markdown
Contributor

Description

Connected Issues

Checklist

  • Tests added/updated and ran with npm run test OR no tests needed.
  • Ran backwards compatibility tests with npm run test:backwards-compatibility.
  • Code formatted and checked with npm run lint.
  • Tested airdrop-template linked to this PR.
  • Documentation updated and provided a link to PR / new docs OR no docs needed.

@gasperzgonec
gasperzgonec requested review from a team and radovanjorgic as code owners July 15, 2026 11:28
@radovanjorgic radovanjorgic changed the title Reduce retries for ERRCONNABORTED error when uploading attachments fix: reduce retries for ERRCONNABORTED error when uploading attachments Jul 16, 2026
@gasperzgonec
gasperzgonec merged commit c1adc61 into main Jul 16, 2026
9 checks passed
@gasperzgonec
gasperzgonec deleted the gasperz/ASCPT-44 branch July 16, 2026 10:53
radovanjorgic added a commit that referenced this pull request Jul 21, 2026
…ONNABORTED retry cap (#222)

v2 branched from main at 9a16ab2 and its "merge main" commit was a no-op,
so two fixes that landed on main afterward were never brought over:

- #210 (b9cef1f): worker_metadata state dates + per-item-type created/modified
  date ranges on data/attachment done+progress emits, and Artifact date fields.
  Re-applied onto the refactored files: state dates live in emit.ts (was
  control-protocol.ts); the item-type/date-range stats move to a new
  buildWorkerMetadata() template hook on ExtractionAdapter (was inline in
  worker-adapter.emit); repo.ts tracks dateRanges; uploader spreads
  computeArtifactDateRanges into the artifact.
- #222 (c1adc61): disable axios-retry on guessed Content-Length uploads to stop
  the ECONNABORTED retry storm.

Restores byte-for-byte wire parity with v1 and the documented HTTP retry
behavior. Ported the accompanying tests that map onto surviving v2 files
(repo.helpers, computeArtifactDateRanges, streamArtifact retry). 442 tests pass.
radovanjorgic added a commit that referenced this pull request Jul 21, 2026
Add the fully-autonomous v1->v2 (@devrev/ts-adaas -> @devrev/airsync-sdk)
connector migration skill under skills/migrate-v2/ (SKILL.md + transform
catalog + symbol map), covering all 16 breaking-change categories and
validated against the 5 reference connectors.

Add V2_MIGRATION_NOTES.md recording the regression audit, the #210/#222
forward-port, known MIGRATION.md inaccuracies, and the open legacy
event-type routing item to confirm before GA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants