Skip to content

Double quotes in passwords are not escaped #43

@erikhh

Description

@erikhh

First of all, thank you for creating this wonderful piece of kit! It is ridiculously useful.

We're using SASL-SCRAM login on our Kafka, but looking at the code this issue would be applicable to all JAAS usernames and passwords.
Our passwords are randomly generated and occasionally contain double quote characters ("). The config for the gitops user looks somewhat like this:

sasl.jaas.config=org.apache.kafka.common.security.scram.ScramLoginModule required username="my-gitops-user" password="XXXXXXXXX"YYYYY";

Then when running 'kafka-gitops plan` it gives this error:

[ERROR] Error thrown when creating Kafka admin client:
Value not specified for key 'YYYYY' in JAAS config

I had a look at the code. And it looks easy enough to fix. I'll submit a PR for this later tonight if that's ok with you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions