fix: after a refresh cheatsheet title anchor not working#1011
Merged
sabbirshawon merged 2 commits intodevsonket:developfrom Oct 7, 2023
Merged
fix: after a refresh cheatsheet title anchor not working#1011sabbirshawon merged 2 commits intodevsonket:developfrom
sabbirshawon merged 2 commits intodevsonket:developfrom
Conversation
as sheet component is rendered for every cheatsheet page.. the page has already a path like `https://devsonket.com/bootstrap5` here `/bootstrap5` is the path which is the id of current viewing cheatsheet.. sheet component has a title with an anchor tag for every title, in the anchor tag href `${slug}#{title}` is being used... that's why after a refresh /slug#title is added to the URL like this `https://devsonket.com/bootstrap5/bootstrap5#title`
✅ Deploy Preview for devsonket ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sabbirshawon
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes this issue #987
if you can find the problem following the mentioned issue
and compare with this pr deployed URL, you'll see the difference