Skip to content

feat: add managerfactory package for generated register imports#8

Merged
skevetter merged 2 commits into
mainfrom
fix/add-managerfactory-package
Apr 18, 2026
Merged

feat: add managerfactory package for generated register imports#8
skevetter merged 2 commits into
mainfrom
fix/add-managerfactory-package

Conversation

@skevetter

@skevetter skevetter commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Without this package, consumers get a build failure when running deepcopy-gen or other generators that parse the generated register files:

no required module provides package github.com/devsy-org/apiserver/pkg/managerfactory

The register generator template references managerfactory.SharedManagerFactory
in the NewRESTFunc type signature. Move this interface definition into
apiserver so consumers don't need to define it separately.
@coderabbitai

coderabbitai Bot commented Apr 18, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 19 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 20 minutes and 19 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a28016bf-061d-4246-8d00-8bdb0d49830f

📥 Commits

Reviewing files that changed from the base of the PR and between 8bc6dab and 7ff7463.

📒 Files selected for processing (1)
  • pkg/managerfactory/types.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-managerfactory-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter enabled auto-merge (squash) April 18, 2026 19:48
@skevetter
skevetter merged commit 48815a4 into main Apr 18, 2026
5 checks passed
@skevetter
skevetter deleted the fix/add-managerfactory-package branch April 18, 2026 19:58
This was referenced Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant