Skip to content

test(e2e): use x-access-token for GitHub App token credentials #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Apr 19, 2026
Merged

test(e2e): use x-access-token for GitHub App token credentials #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/act.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,11 @@ jobs:
env:
GH_USERNAME: ${{ github.repository_owner }}
GH_ACCESS_TOKEN: ${{ steps.app-token.outputs.token || github.token }}
GH_CREDENTIAL_USERNAME: x-access-token
run: |
GH_USERNAME="${GH_USERNAME}" \
GH_ACCESS_TOKEN="${GH_ACCESS_TOKEN}" \
GH_CREDENTIAL_USERNAME="${GH_CREDENTIAL_USERNAME}" \
KUBECONFIG="${KUBECONFIG:-$HOME/.kube/config}" \
PATH="${PATH}" \
GOROOT="${GOROOT}" \
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,18 +374,21 @@ jobs:
# NOTE: GitHub credentials are required for tests using private repos
GH_USERNAME: ${{ github.repository_owner }}
GH_ACCESS_TOKEN: ${{ steps.app-token.outputs.token || github.token }}
GH_CREDENTIAL_USERNAME: x-access-token
run: |
if [ "${{ runner.os }}" == "Linux" ]; then
sudo \
GH_USERNAME="${GH_USERNAME}" \
GH_ACCESS_TOKEN="${GH_ACCESS_TOKEN}" \
GH_CREDENTIAL_USERNAME="${GH_CREDENTIAL_USERNAME}" \
KUBECONFIG="${KUBECONFIG:-$HOME/.kube/config}" \
PATH="${PATH}" \
GOROOT="${GOROOT}" \
go test -v -ginkgo.v -timeout 900s --ginkgo.label-filter="${{ matrix.label }}"
else
GH_USERNAME="${GH_USERNAME}" \
GH_ACCESS_TOKEN="${GH_ACCESS_TOKEN}" \
GH_CREDENTIAL_USERNAME="${GH_CREDENTIAL_USERNAME}" \
KUBECONFIG="${KUBECONFIG:-$HOME/.kube/config}" \
PATH="${PATH}" \
GOROOT="${GOROOT}" \
Expand Down
8 changes: 7 additions & 1 deletion e2e/tests/up/up_private_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ var _ = ginkgo.Describe(
ginkgo.Skip("GH_USERNAME and GH_ACCESS_TOKEN must be set")
}

// GitHub App tokens require "x-access-token" as the credential username
credUser := os.Getenv("GH_CREDENTIAL_USERNAME")
if credUser == "" {
credUser = username
}

f, err := setupDockerProvider(initialDir+"/bin", "docker")
framework.ExpectNoError(err)

Expand All @@ -41,7 +47,7 @@ var _ = ginkgo.Describe(
Run()
framework.ExpectNoError(err)

gitCredentialString := []byte("https://" + username + ":" + token + "@github.com")
gitCredentialString := []byte("https://" + credUser + ":" + token + "@github.com")
err = os.WriteFile(credentialPath, gitCredentialString, 0o600)
framework.ExpectNoError(err)

Expand Down
Loading