Skip to content

fix(lint): resolve staticcheck S1008 and ST1005 findings - #877

Merged
skevetter merged 2 commits into
mainfrom
lint/staticcheck-s1008-st1005
Aug 4, 2026
Merged

fix(lint): resolve staticcheck S1008 and ST1005 findings#877
skevetter merged 2 commits into
mainfrom
lint/staticcheck-s1008-st1005

Conversation

@skevetter

@skevetter skevetter commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the two smallest staticcheck findings, grouped together since each is a one-line fix:

  • pkg/tunnel/services.go: simplifies the retry.OnError predicate from if ctx.Err() != nil { return false }; return true to return ctx.Err() == nil (S1008).
  • cmd/pro/start.go: suppresses ErrLoftNotReachable's ST1005 finding (capitalized error string) with a //nolint -- "Devsy Pro" is a proper noun, not a fixable style issue.

No behavior changes. The remaining staticcheck findings (8 SA1019 deprecation warnings) point at larger API migrations (MCP SDK logging, legacy shell-injection path, k8s httpstream) and are out of scope -- tracked separately, not suppressed, so they stay visible.

Summary by CodeRabbit

  • Bug Fixes

    • Service startup retries now stop promptly when cancellation is requested, improving shutdown responsiveness and preventing unnecessary retry activity.
  • Chores

    • Improved code quality and diagnostics around service error handling without changing the public interface.

- pkg/tunnel/services.go: simplify the retry.OnError predicate to
  `return ctx.Err() == nil` (S1008).
- cmd/pro/start.go: suppress ErrLoftNotReachable's ST1005
  (capitalized error string) since "Devsy Pro" is a proper noun, not
  a fixable style issue.

No behavior changes.
@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit 20b43a6
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a713da0a08292000806f076

@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit 20b43a6
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a713da0554be20007ce3d2e

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@skevetter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c497d3aa-d948-4026-8a3a-85c19b2e35bc

📥 Commits

Reviewing files that changed from the base of the PR and between 18ef72b and 20b43a6.

📒 Files selected for processing (1)
  • cmd/pro/start.go
📝 Walkthrough

Walkthrough

The change adds a proper-noun lint suppression and simplifies the RunServices retry predicate to return ctx.Err() == nil directly.

Changes

Lint suppression

Layer / File(s) Summary
Proper-noun lint suppression
cmd/pro/start.go
Adds a staticcheck suppression comment for the “Devsy Pro” proper noun.

Retry predicate simplification

Layer / File(s) Summary
Context retry check
pkg/tunnel/services.go
Replaces the conditional retry predicate with the direct expression ctx.Err() == nil.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the two staticcheck findings resolved by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@skevetter
skevetter marked this pull request as draft August 4, 2026 00:34
@github-actions github-actions Bot added size/s and removed size/xs labels Aug 4, 2026
Matches the current Devsy Platform naming; "Loft" is legacy.
@skevetter
skevetter force-pushed the lint/staticcheck-s1008-st1005 branch from 1f65d48 to 20b43a6 Compare August 4, 2026 01:17
@skevetter
skevetter marked this pull request as ready for review August 4, 2026 03:46
@skevetter
skevetter merged commit 8e4a1a3 into main Aug 4, 2026
67 checks passed
@skevetter
skevetter deleted the lint/staticcheck-s1008-st1005 branch August 4, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant