Skip to content

fix(lint): resolve function-result-limit findings - #885

Open
skevetter wants to merge 2 commits into
mainfrom
lint/function-result-limit
Open

fix(lint): resolve function-result-limit findings#885
skevetter wants to merge 2 commits into
mainfrom
lint/function-result-limit

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • Bundles setupBuildKitClient's 4 return values into a buildKitClient struct in pkg/devcontainer/buildkit/remote.go
  • Bundles getValue's 5 return values into an existingOptionValue struct in pkg/options/resolver/resolve.go
  • Converts resolveWorkspace, createWorkspace, selectWorkspace, and loadExistingWorkspace in pkg/workspace/workspace.go to return the existing resolvedWorkspace struct instead of 4 positional values (already used by resolveWorkspaceWithoutArgs)

No .golangci.yaml change needed — function-result-limit was already enabled.

Bundle setupBuildKitClient's, getValue's, and workspace resolution's
4-5 return values into single structs (buildKitClient,
existingOptionValue, resolvedWorkspace) instead of returning them
positionally.
@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for images-devsy-sh canceled.

Name Link
🔨 Latest commit f184e01
🔍 Latest deploy log https://app.netlify.com/projects/images-devsy-sh/deploys/6a72f11661c1280009d5a5f9

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@skevetter, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7972380e-9a51-49d4-b91e-4795135daa16

📥 Commits

Reviewing files that changed from the base of the PR and between 66965cf and f184e01.

📒 Files selected for processing (3)
  • pkg/devcontainer/buildkit/remote.go
  • pkg/options/resolver/resolve.go
  • pkg/workspace/workspace.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit f184e01
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/6a72f11618927c000785c4dc

@github-actions github-actions Bot added the size/m label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant