Add ALP-RD to the cascade competition (#304)#307
Merged
Merged
Conversation
AlpRdEncodingEncoder was registered on WriteRegistry but never added to the top-level cascade codec list, so it could only appear as a child encoding, never be selected for an F64/F32 column. High-precision floats that plain ALP cannot fit without an exception on nearly every row (nyc-311 Latitude) therefore fell back to raw vortex.primitive (or dict), while the Rust reference uses vortex.alprd. Add it as a top-level candidate next to ALP. It competes on measured size, so it only wins where it is actually smaller (Latitude flips to alprd; Longitude keeps plain alp). No wire/reader change — alprd is already decodable (the reader reads Rust files that use it). nyc-311 re-encode: 1678.86 MB -> 1644.25 MB (0.95x -> 0.93x vortex-jni). Round-trip + ALP-RD-selection integration test added; 217 Java-writes-Rust-reads interop tests pass; full verify green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AlpRdEncodingEncoderwas registered onWriteRegistrybut never added to the top-level cascade codec list, so it could only appear as a child encoding — never be selected for an F64/F32 column. High-precision floats that plain ALP can't fit without an exception on nearly every row fell back to rawvortex.primitive(or dict), while the Rust reference usesvortex.alprd.Encoding tree for nyc-311 Latitude:
How
Add
AlpRdEncodingEncoderto the cascade competition next toAlpEncodingEncoder. It competes on measured size, so it only wins where it's actually smaller: Latitude flips toalprd, Longitude keeps plainalp. No wire/reader change —alprdis already decodable (the reader reads Rust files that use it; the 217-test interop suite confirms).Impact (real nyc-311 corpus)
−34.6 MB — java is now 118 MB under the Rust reference on nyc-311.
Testing
vortex.alprdvia the cascade and round-trips../mvnw verifygreen.Closes #304.