Revert leaf mock wrapper generation#238
Merged
Merged
Conversation
dfed
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 5715 5772 +57
=========================================
+ Hits 5715 5772 +57
🚀 New features to boost your workflow:
|
dfed
commented
Apr 10, 2026
dfed
commented
Apr 10, 2026
Co-authored-by: Dan Federman <dfed@me.com>
dfed
added a commit
that referenced
this pull request
Apr 10, 2026
Protocol extensions cannot contain nested type declarations. When a dependency's instantiated type is a protocol (e.g., AuthService fulfilled by DefaultAuthService), the generated SafeDIMockConfiguration must be nested in the concrete type's extension, not the protocol's. This reverts the #238 change from concreteType to instantiatedTypeDescription for configurationTypeName and collectUniqueConfigurationTypes dedup key. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
dfed
added a commit
that referenced
this pull request
Apr 10, 2026
## Summary - Protocol extensions cannot contain nested type declarations - When a dependency's instantiated type is a protocol (e.g., `AuthService` fulfilled by `DefaultAuthService`), the generated `SafeDIMockConfiguration` must be nested in the concrete type's extension, not the protocol's - Reverts #238's change from `concreteType` to `instantiatedTypeDescription` for `configurationTypeName` and dedup key - This bug exists on main but is rarely triggered — protocol-typed deps that `needsConfigurationStruct` (have children) are uncommon without the onlyIfAvailable tree-threading changes ## Test plan - [x] All 742 tests pass - [x] SwiftFormat lint passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SafeDIMockConfigurationWhy
The always-wrapper change appears to have caused a meaningful compile-time regression in the Apple repo after the
2.0.0-alpha-14bump. Reverting just that generated API change lets us preserve the launch fallback fix while removing the extra mock-wrapper surface area.What changed
needsConfigurationStruct-based branching in mock generationSafeDIParametersand child configsPlugins/Shared.swiftandPlugins/SafeDIGenerator/SafeDIGenerateDependencyTree.swiftunchanged so the local source fallback still only triggers on tool launch failuresValidation
swift build --traits sourceBuildswift test --traits sourceBuild./CLI/lint.sh