Use concreteType for SafeDIMockConfiguration struct extensions#243
Merged
Conversation
Protocol extensions cannot contain nested type declarations. When a dependency's instantiated type is a protocol (e.g., AuthService fulfilled by DefaultAuthService), the generated SafeDIMockConfiguration must be nested in the concrete type's extension, not the protocol's. This reverts the #238 change from concreteType to instantiatedTypeDescription for configurationTypeName and collectUniqueConfigurationTypes dedup key. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
===========================================
- Coverage 100.00% 99.98% -0.02%
===========================================
Files 41 41
Lines 5772 5772
===========================================
- Hits 5772 5771 -1
- Misses 0 1 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuthServicefulfilled byDefaultAuthService), the generatedSafeDIMockConfigurationmust be nested in the concrete type's extension, not the protocol'sconcreteTypetoinstantiatedTypeDescriptionforconfigurationTypeNameand dedup keyneedsConfigurationStruct(have children) are uncommon without the onlyIfAvailable tree-threading changesTest plan
🤖 Generated with Claude Code