fix: update unity_ii_deeplink code references in IAM security guide#312
Merged
Conversation
The example was migrated from dfx to icp-cli (dfinity/examples#1440). The ii-bridge frontend moved from ii_integration_dapp/src/greet_frontend/src/index.js to ii-bridge/src/main.js Update all five bullet-point references: - Middle key generation: main.js#L84 - Auth with middle key: main.js#L88-L89 - Delegation chain creation: main.js#L102-L108 - URI fragment callback: main.js#L130-L133 (clarify it uses a custom URL scheme by default, with a link to the README for upgrading to Android App Links / iOS Universal Links) - Delegation chain verification: DeepLinkPlugin.cs#L92-L98 (now implemented; replaces the stale "currently being improved" note) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace two em-dashes with colons per writing guidelines - Update DeepLinkPlugin.cs line reference from L92-L98 to L105-L111; the verification block shifted after the null guard was added to Start() in a subsequent commit
raymondk
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The IAM security guide references specific lines in the
unity_ii_deeplinkexample to illustrate the double-delegation pattern. Those references pointed to a file that no longer exists (ii_integration_dapp/src/greet_frontend/src/index.js) because the example was migrated to icp-cli in dfinity/examples#1440.This PR updates all five bullet points under the "For more information" section (lines 244–249) to the new paths and correct line numbers:
ii-bridge/src/main.js#L84(ECDSAKeyIdentity.generate())ii-bridge/src/main.js#L88-L89(passingmiddleKeyIdentitytoAuthClient)ii-bridge/src/main.js#L102-L108(DelegationChain.createwithprevious: middleIdentity.getDelegation())ii-bridge/src/main.js#L130-L133— clarified that the example uses a custom URL scheme by default, with a link to the README for upgrading to Android App Links / iOS Universal Links for productionunity_project/Assets/Scripts/DeepLinkPlugin.cs#L92-L98— this is now implemented; replaces the stale "currently being improved" noteDependencies
Test plan