chore: DEFI-2304 remove deprecated ic-cdk imports in ic-icp-archive#10318
Draft
gregorydemay wants to merge 1 commit into
Draft
chore: DEFI-2304 remove deprecated ic-cdk imports in ic-icp-archive#10318gregorydemay wants to merge 1 commit into
gregorydemay wants to merge 1 commit into
Conversation
Migrate the ICP archive canister off `ic_cdk::api::call::{arg_data_raw, reply,
reply_raw}`, `ic_cdk::api::{caller, print}` and `ic_cdk::api::stable::stable_size`
(all deprecated in #6264), and drop the file-level `#![allow(deprecated)]`. The
call sites now use `ic_cdk::api::{msg_arg_data, msg_caller, msg_reply, debug_print}`
and `ic_cdk::stable::stable_size`; the few `reply(tuple)` sites are rewritten as
`msg_reply(candid::Encode!(...).unwrap())` to preserve the same Candid output.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated ic-cdk API usage from the ICP archive canister and drops the file-level deprecated allowance, continuing the DEFI-2304 migration with no intended behavior change.
Changes:
- Replaces deprecated argument/reply/caller/logging APIs with
msg_arg_data,msg_reply,msg_caller, anddebug_print. - Rewrites manual Candid replies using
candid::Encode!. - Updates stable memory metric calls to use
ic_cdk::stable::stable_size.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends DEFI-2304 — removing the file-level
#![allow(deprecated)]attribute introduced in #6264.This PR handles
ic-icp-archive:ic_cdk::api::call::{arg_data_raw, reply, reply_raw}→ic_cdk::api::{msg_arg_data, msg_reply}.ic_cdk::api::caller→ic_cdk::api::msg_caller.ic_cdk::api::print→ic_cdk::api::debug_print.ic_cdk::api::stable::stable_size→ic_cdk::stable::stable_size.The few
reply(tuple)sites are rewritten asmsg_reply(candid::Encode!(...).unwrap())so the on-wire Candid output is unchanged. No behavior change.Follows the pattern set by #6755 (
ic-btc-checker), #6761 (ic-ckbtc-minter), #10289, #10290, #10291, and #10317.