Skip to content

chore: upgrade rules_motoko and bump Motoko compiler to 1.11.0#10688

Merged
basvandijk merged 7 commits into
masterfrom
basvandijk/upgrade-rules-motoko-1.11.0
Jul 8, 2026
Merged

chore: upgrade rules_motoko and bump Motoko compiler to 1.11.0#10688
basvandijk merged 7 commits into
masterfrom
basvandijk/upgrade-rules-motoko-1.11.0

Conversation

@basvandijk

@basvandijk basvandijk commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

To prepare for the introduction of the motoko-based cloud engine canister this commit upgrades motoko
from 0.16.3 to 1.11.0 (latest release).

- Bump rules_motoko to latest main commit (0c3d815c) and set the
  motoko toolchain version to 1.11.0.
- Update the moc compiler used by Cargo in the CI container to 1.11.0
  (published on the caffeinelabs/motoko fork).
- Note the lifeline canister compiler bump in the changelog.
@basvandijk basvandijk requested a review from Copilot July 7, 2026 20:01
@basvandijk basvandijk changed the title Upgrade rules_motoko and bump Motoko compiler to 1.11.0 chore: upgrade rules_motoko and bump Motoko compiler to 1.11.0 Jul 7, 2026
@github-actions github-actions Bot added the chore label Jul 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Bazel Motoko rules/toolchain and the CI container’s Cargo-used moc to Motoko compiler 1.11.0, and records the lifeline canister compiler bump in the unreleased changelog.

Changes:

  • Bump rules_motoko to commit 0c3d815c0c07c5696a4cb3fa8da25834594a5294 and set motoko.toolchain(version = "1.11.0") in MODULE.bazel.
  • Update the CI container’s downloaded Motoko compiler to 1.11.0 from caffeinelabs/motoko (including filename casing change).
  • Add an unreleased changelog entry noting the lifeline canister compiler bump.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
rs/nns/handlers/lifeline/unreleased_changelog.md Adds an unreleased note about compiling lifeline with Motoko 1.11.0.
MODULE.bazel Updates the rules_motoko override and sets Motoko toolchain version to 1.11.0.
ci/container/Dockerfile Switches the Cargo-used moc download to caffeinelabs’ Motoko 1.11.0 release asset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rs/nns/handlers/lifeline/unreleased_changelog.md Outdated
Comment thread ci/container/Dockerfile
…d455ebe9a95c1f7c88992d0b0c4cd

ic-build: sha256:659bf9830b6ec0b640a42568f7e200524e36df104af640e5aedbf21942d5293e

ic-dev:   sha256:0467c0b19793f31b418f8a454394cfa8a28d8affa39a22805643d6b2b0749a74
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Run URL: https://github.com/dfinity/ic/actions/runs/28949109701

New container images with tag: a76da6c4913ea85f179201fa22ca3552e4ad455ebe9a95c1f7c88992d0b0c4cd
ic-build: sha256:6766ee9ed7fff7de14cf8ed86c6db8adc0d6b90788234440bd18c07743099ac0
ic-dev: sha256:b0c0702f842bcdf82ab48f82e70d204398e8b6cc0b0fb29b92552a7704862d54

@basvandijk basvandijk marked this pull request as ready for review July 7, 2026 20:08
@basvandijk basvandijk requested review from a team as code owners July 7, 2026 20:08

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@zeropath-ai

zeropath-ai Bot commented Jul 7, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 787f12c.

Security Overview
Detected Code Changes
Change Type Relevant files
Configuration changes ► MODULE.bazel
    Update Motoko rules_motoko integrity/strip_prefix and version
► MODULE.bazel
    Update Motoko toolchain version
► ci/container/Dockerfile
    Update motoko_version ARG and download source to new URL and path
► ci/container/Dockerfile
    Use updated Motoko tarball URL and extraction path
Bug Fix ► ci/container/Dockerfile
    Change Motoko download URL and extraction command to reflect new distribution
► rs/nns/handlers/lifeline/unreleased_changelog.md
    Update changelog entry to reflect new compiler version
Other ► rs/nns/handlers/lifeline/unreleased_changelog.md
    Modify Changed section to reference new Motoko compiler version

@basvandijk basvandijk dismissed github-actions[bot]’s stale review July 7, 2026 20:15

This changes the lifeline canister since it's now build with motoko 1.11.0 instead of the previous 0.16.3. This shouldn't change its behaviour. It has been noted in its changelog.

Comment thread rs/nns/handlers/lifeline/unreleased_changelog.md Outdated
basvandijk and others added 2 commits July 8, 2026 13:19
…be7f49b5528e73804be39740cfe5f

ic-build: sha256:845d9ce4f79ac8c17de52bb31649f4670fb6a80fccc5f0bd97c3455626d464c6

ic-dev:   sha256:692dbce784c64a26c879ab9b5e6c0a6d5a6dce3e3056e3d31566049f02e84262
…d455ebe9a95c1f7c88992d0b0c4cd

ic-build: sha256:6766ee9ed7fff7de14cf8ed86c6db8adc0d6b90788234440bd18c07743099ac0

ic-dev:   sha256:b0c0702f842bcdf82ab48f82e70d204398e8b6cc0b0fb29b92552a7704862d54
@basvandijk basvandijk merged commit 5620811 into master Jul 8, 2026
44 checks passed
@basvandijk basvandijk deleted the basvandijk/upgrade-rules-motoko-1.11.0 branch July 8, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants