chore: upgrade rules_motoko and bump Motoko compiler to 1.11.0#10688
Conversation
- Bump rules_motoko to latest main commit (0c3d815c) and set the motoko toolchain version to 1.11.0. - Update the moc compiler used by Cargo in the CI container to 1.11.0 (published on the caffeinelabs/motoko fork). - Note the lifeline canister compiler bump in the changelog.
There was a problem hiding this comment.
Pull request overview
Updates the Bazel Motoko rules/toolchain and the CI container’s Cargo-used moc to Motoko compiler 1.11.0, and records the lifeline canister compiler bump in the unreleased changelog.
Changes:
- Bump
rules_motokoto commit0c3d815c0c07c5696a4cb3fa8da25834594a5294and setmotoko.toolchain(version = "1.11.0")inMODULE.bazel. - Update the CI container’s downloaded Motoko compiler to
1.11.0fromcaffeinelabs/motoko(including filename casing change). - Add an unreleased changelog entry noting the
lifelinecanister compiler bump.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rs/nns/handlers/lifeline/unreleased_changelog.md | Adds an unreleased note about compiling lifeline with Motoko 1.11.0. |
| MODULE.bazel | Updates the rules_motoko override and sets Motoko toolchain version to 1.11.0. |
| ci/container/Dockerfile | Switches the Cargo-used moc download to caffeinelabs’ Motoko 1.11.0 release asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d455ebe9a95c1f7c88992d0b0c4cd ic-build: sha256:659bf9830b6ec0b640a42568f7e200524e36df104af640e5aedbf21942d5293e ic-dev: sha256:0467c0b19793f31b418f8a454394cfa8a28d8affa39a22805643d6b2b0749a74
|
Run URL: https://github.com/dfinity/ic/actions/runs/28949109701 New container images with tag: |
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
✅ No security or compliance issues detected. Reviewed everything up to 787f12c. Security Overview
Detected Code Changes
|
This changes the lifeline canister since it's now build with motoko 1.11.0 instead of the previous 0.16.3. This shouldn't change its behaviour. It has been noted in its changelog.
…rules-motoko-1.11.0
…be7f49b5528e73804be39740cfe5f ic-build: sha256:845d9ce4f79ac8c17de52bb31649f4670fb6a80fccc5f0bd97c3455626d464c6 ic-dev: sha256:692dbce784c64a26c879ab9b5e6c0a6d5a6dce3e3056e3d31566049f02e84262
…rules-motoko-1.11.0
…d455ebe9a95c1f7c88992d0b0c4cd ic-build: sha256:6766ee9ed7fff7de14cf8ed86c6db8adc0d6b90788234440bd18c07743099ac0 ic-dev: sha256:b0c0702f842bcdf82ab48f82e70d204398e8b6cc0b0fb29b92552a7704862d54
To prepare for the introduction of the motoko-based cloud engine canister this commit upgrades motoko
from 0.16.3 to 1.11.0 (latest release).