chore(idkg): update ID generator's height together with the transcripts' references - #11156
Merged
pierugo-dfinity merged 2 commits intoAug 18, 2026
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to c46bde9. Security Overview
Detected Code Changes
|
eichhorl
approved these changes
Aug 17, 2026
pierugo-dfinity
deleted the
pierugo/idkg/update-uid-generator-inside-update-refs
branch
August 18, 2026 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the ID generator's height update inside the payload's
update_refsfunction, which does the same thing for all transcript references. I do not think there is a good reason to update one but not the others, so it is less error-prone to update everything together in the same function.Also, adds a unit test ensuring these references are actually updated when building a summary payload.