Skip to content

chore(idkg): update ID generator's height together with the transcripts' references - #11156

Merged
pierugo-dfinity merged 2 commits into
masterfrom
pierugo/idkg/update-uid-generator-inside-update-refs
Aug 18, 2026
Merged

chore(idkg): update ID generator's height together with the transcripts' references#11156
pierugo-dfinity merged 2 commits into
masterfrom
pierugo/idkg/update-uid-generator-inside-update-refs

Conversation

@pierugo-dfinity

@pierugo-dfinity pierugo-dfinity commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This PR moves the ID generator's height update inside the payload's update_refs function, which does the same thing for all transcript references. I do not think there is a good reason to update one but not the others, so it is less error-prone to update everything together in the same function.

Also, adds a unit test ensuring these references are actually updated when building a summary payload.

@github-actions github-actions Bot added the chore label Aug 17, 2026
@pierugo-dfinity
pierugo-dfinity marked this pull request as ready for review August 17, 2026 13:12
@pierugo-dfinity
pierugo-dfinity requested a review from a team as a code owner August 17, 2026 13:12
@zeropath-ai

zeropath-ai Bot commented Aug 17, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to c46bde9.

Security Overview
Detected Code Changes
Change Type Relevant files
Bug Fix ► rs/consensus/idkg/src/payload_builder.rs
    Fix update_refs call order and UID height update in create_summary_payload_helper and update_summary_refs
► rs/types/types/src/consensus/idkg.rs
    Adjust update_refs to return Result and propagate UID update, then apply to key_transcripts

@pierugo-dfinity
pierugo-dfinity added this pull request to the merge queue Aug 18, 2026
Merged via the queue into master with commit 2c31ebb Aug 18, 2026
44 checks passed
@pierugo-dfinity
pierugo-dfinity deleted the pierugo/idkg/update-uid-generator-inside-update-refs branch August 18, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants