chore: Limit port 19522 (SEV key exchange server) to be called by the peer VM only - #11440
Merged
Conversation
frankdavid
requested review from
r-birkner
and
a balanced review from Copilot
September 3, 2026 16:21
|
✅ No security or compliance issues detected. Reviewed everything up to 42ef6a2. Security Overview
Detected Code Changes
|
|
✅ No security or compliance issues detected. Reviewed everything up to 42ef6a2. Security Overview
Detected Code Changes
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes have no unresolved approval-blocking issues.
Pull request overview
Restricts SEV key-exchange port 19522 to the configured peer Guest VM.
Changes:
- Adds peer-address-aware nftables rules.
- Updates firewall golden files and rendering tests.
- Clarifies test-driver firewall documentation.
File summaries
| File | Description |
|---|---|
rs/tests/driver/src/util.rs |
Supplies the optional peer-address template field. |
rs/tests/driver/src/driver/ic.rs |
Documents the restricted port. |
rs/orchestrator/testdata/nftables_unassigned_replica.conf.golden |
Updates unassigned replica rules. |
rs/orchestrator/testdata/nftables_unassigned_cloud_engine.conf.golden |
Updates unassigned cloud-engine rules. |
rs/orchestrator/testdata/nftables_boundary_node_system_subnet.conf.golden |
Updates system-subnet boundary-node rules. |
rs/orchestrator/testdata/nftables_boundary_node_app_subnet.conf.golden |
Updates app-subnet boundary-node rules. |
rs/orchestrator/testdata/nftables_assigned_replica.conf.golden |
Updates assigned replica rules. |
rs/orchestrator/testdata/nftables_assigned_cloud_engine.conf.golden |
Updates assigned cloud-engine rules. |
rs/orchestrator/src/firewall.rs |
Provides a peer address to golden tests. |
rs/ic_os/config/tool/templates/ic.json5.template |
Restricts port 19522 to the peer address. |
rs/ic_os/config/tool/src/guestos/generate_ic_config.rs |
Propagates and tests the peer address. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
basvandijk
approved these changes
Sep 3, 2026
Bownairo
approved these changes
Sep 3, 2026
pierugo-dfinity
approved these changes
Sep 4, 2026
r-birkner
approved these changes
Sep 4, 2026
r-birkner
left a comment
r-birkner
left a comment
Contributor
There was a problem hiding this comment.
Looks good! The change will be active at the next upgrade. So, we will only see an issue at the next next upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.