Skip to content

chore: use --execution_log_compact_file to prevent OOM#4916

Merged
basvandijk merged 32 commits into
masterfrom
basvandijk/execution_log_compact_to_csv.py
Apr 29, 2025
Merged

chore: use --execution_log_compact_file to prevent OOM#4916
basvandijk merged 32 commits into
masterfrom
basvandijk/execution_log_compact_to_csv.py

Conversation

@basvandijk

Copy link
Copy Markdown
Collaborator

Enabling the hermetic CC toolchain (again) in #4848 is causing an Out Of Memory error at the end of the bazel test invocation because we use --execution_log_json_file. We fix this by using the more CPU and memory efficient --execution_log_compact_file and converting the resulting zstandard compressed length-delimited protobuf-encoded file to CSV using a Python program.

@basvandijk basvandijk changed the title xchore: use --execution_log_compact_file to prevent OOM chore: use --execution_log_compact_file to prevent OOM Apr 28, 2025
@github-actions github-actions Bot added the chore label Apr 28, 2025
@basvandijk basvandijk force-pushed the basvandijk/execution_log_compact_to_csv.py branch from 3672f7b to 2085acd Compare April 28, 2025 17:59
@basvandijk basvandijk marked this pull request as ready for review April 28, 2025 18:01
@basvandijk basvandijk requested a review from a team as a code owner April 28, 2025 18:01
@github-actions github-actions Bot added the @idx label Apr 28, 2025
Comment thread .github/actions/bazel/action.yaml
Comment thread .github/actions/bazel/action.yaml Outdated
Comment thread .github/actions/bazel/action.yaml Outdated
Comment thread bazel/execution_log_compact_to_csv.py Outdated
Comment thread bazel/execution_log_compact_to_csv.py
Comment thread bazel/execution_log_compact_to_csv.py Outdated
Comment thread bazel/execution_log_compact_to_csv.py Outdated
Comment thread bazel/execution_log_compact_to_csv.py Outdated
Comment thread bazel/spawn_proto_library.bzl
@basvandijk basvandijk requested a review from nmattia April 29, 2025 10:02
Comment thread .github/actions/bazel/action.yaml Outdated

@nmattia nmattia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@basvandijk basvandijk added this pull request to the merge queue Apr 29, 2025
Merged via the queue into master with commit 4151547 Apr 29, 2025
@basvandijk basvandijk deleted the basvandijk/execution_log_compact_to_csv.py branch April 29, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants