feat(nns): Added setting neuron visibility.#517
Merged
daniel-wong-dfinity-org merged 3 commits intoJul 23, 2024
Conversation
daniel-wong-dfinity-org
force-pushed
the
set-neuron-visibility-daniel-wong
branch
from
849d347 to
b5c7702
Compare
Base automatically changed from
known-neurons-are-always-public-daniel-wong
to
master
July 22, 2024 13:21
daniel-wong-dfinity-org
force-pushed
the
set-neuron-visibility-daniel-wong
branch
from
b5c7702 to
80c7c7e
Compare
daniel-wong-dfinity-org
force-pushed
the
set-neuron-visibility-daniel-wong
branch
from
647ba7c to
fe1b4de
Compare
daniel-wong-dfinity-org
force-pushed
the
set-neuron-visibility-daniel-wong
branch
from
fe1b4de to
10e0f73
Compare
anchpop
approved these changes
Jul 23, 2024
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…s. (#589) [Per the plan](https://forum.dfinity.org/t/request-for-comments-api-changes-for-public-private-neurons/33360). The upshot is that people can now read public neurons. # Entrained Changes(s) Fixed a bug from a [recent change of mine](#488) where neuron normalization was not applied 😬 Renamed list_neurons_by_principal to list_neurons in order to exactly match the Candid method name. Also, changed its &PrincipalId parameter to be of type PrincipalId, since that type is Copy. Overhauled the implementation of (what is now called) Governance::list_neurons. This is the main thing I was touching anyway, but the change could have been smaller. Added NeuronStore::can_principal_vote_on_proposals_that_target_neuron. Refactored NeuronStore::get_full_neuron to use can_principal_vote_on_proposals_that_target_neuron. # References Closes [NNS1-3077](https://dfinity.atlassian.net/browse/NNS1-3077) [<< Previous PR](#517) [NNS1-3077]: https://dfinity.atlassian.net/browse/NNS1-3077?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the visibility of known neurons is not allowed, per the plan.
As described here.
Entrained change: Added implementations of Command::from(struct) and Operation::from(struct). If desired, this could be split off pretty easily into another PR, because these changes are in their own commit (thanks to git rebase -i).
Closes NNS1-3073.
Closes NNS1-3082.
<< Previous PR | Next PR >>