feat(nns): Added include_public_neurons_in_full_neurons to ListNeurons.#589
Merged
daniel-wong-dfinity-org merged 7 commits intoJul 26, 2024
Conversation
daniel-wong-dfinity-org
force-pushed
the
include_public_neurons_in_full_neurons-daniel-wong
branch
2 times, most recently
from
d58d7ac to
a8b976f
Compare
daniel-wong-dfinity-org
force-pushed
the
include_public_neurons_in_full_neurons-daniel-wong
branch
from
d7d40cf to
8507608
Compare
daniel-wong-dfinity-org
changed the title
daniel-wong-dfinity-org
force-pushed
the
include_public_neurons_in_full_neurons-daniel-wong
branch
2 times, most recently
from
14eb4ee to
5ac301e
Compare
marko-k0
approved these changes
Jul 25, 2024
basvandijk
approved these changes
Jul 25, 2024
max-dfinity
reviewed
Jul 25, 2024
NikolasHaimerl
approved these changes
Jul 25, 2024
jasonz-dfinity
approved these changes
Jul 26, 2024
…ts &PrincipalId parameter to just PrincipalId. The name change is to match the Candid method.
… my previous MR: there was a path where Neuron normalization was not applied. This fixes that.
… ListNeurons Rust struct by simply adding new_field: None.
…s the last one???)
daniel-wong-dfinity-org
force-pushed
the
include_public_neurons_in_full_neurons-daniel-wong
branch
from
0ef28dc to
cefcf75
Compare
max-dfinity
approved these changes
Jul 26, 2024
daniel-wong-dfinity-org
deleted the
include_public_neurons_in_full_neurons-daniel-wong
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the plan.
The upshot is that people can now read public neurons.
Entrained Changes(s)
Fixed a bug from a recent change of mine where neuron normalization was not applied 😬
Renamed list_neurons_by_principal to list_neurons in order to exactly match the Candid method name. Also, changed its &PrincipalId parameter to be of type PrincipalId, since that type is Copy.
Overhauled the implementation of (what is now called) Governance::list_neurons. This is the main thing I was touching anyway, but the change could have been smaller.
Added NeuronStore::can_principal_vote_on_proposals_that_target_neuron.
Refactored NeuronStore::get_full_neuron to use can_principal_vote_on_proposals_that_target_neuron.
References
Closes NNS1-3077
<< Previous PR