Skip to content

test(node): Update dev launch measurement calculation#8684

Merged
andrewbattat merged 2 commits intomasterfrom
andrew/update-dev-launch-measurment
Feb 5, 2026
Merged

test(node): Update dev launch measurement calculation#8684
andrewbattat merged 2 commits intomasterfrom
andrew/update-dev-launch-measurment

Conversation

@andrewbattat
Copy link
Copy Markdown
Contributor

@andrewbattat andrewbattat commented Feb 5, 2026

The pre-generated dev launch measurement should match the actual dev SEV launch measurement. This fixes a bug where a dev SEV node is unable to join a dev testnet because the blessed version contained a "prod" measurement.

Fix: correct the vcpus used in the pre-generated dev launch measurement to match the dev defaults (in deployment.json.template).

@andrewbattat andrewbattat self-assigned this Feb 5, 2026
@github-actions github-actions Bot added the test label Feb 5, 2026
@andrewbattat andrewbattat marked this pull request as ready for review February 5, 2026 03:48
@andrewbattat andrewbattat requested a review from a team as a code owner February 5, 2026 03:48
@github-actions github-actions Bot added the @node label Feb 5, 2026
Comment thread ic-os/defs.bzl Outdated
@andrewbattat andrewbattat added this pull request to the merge queue Feb 5, 2026
Merged via the queue into master with commit 918d1a6 Feb 5, 2026
39 checks passed
@andrewbattat andrewbattat deleted the andrew/update-dev-launch-measurment branch February 5, 2026 17:34
kpop-dfinity pushed a commit that referenced this pull request Feb 20, 2026
The pre-generated dev launch measurement should match the actual dev SEV
launch measurement. This fixes a bug where a dev SEV node is unable to
join a dev testnet because the blessed version contained a "prod"
measurement.

Fix: correct the `vcpus` used in the pre-generated dev launch
measurement to match the dev defaults (in deployment.json.template).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants