Skip to content

test(node): Update dev launch measurement calculation #8684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewbattat merged 2 commits into from
Feb 5, 2026
Merged

test(node): Update dev launch measurement calculation #8684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d8aa69
Update dev launch measurement calculation
andrewbattat Feb 5, 2026
8a07e91
Support multiple vcpu measurements
andrewbattat Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions ic-os/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,13 @@ def icos_build(
)

if image_deps.get("generate_launch_measurements", False):
# The vCPU count in the launch measurement must match the GuestOS VM configuration.
#
# For dev images, we generate measurements for multiple vCPU configurations to support
# different common deployment scenarios:
# - 16 vCPUs: local dev testing (per deployment.json.template dev_vm_resources.nr_of_vcpus)
# - 64 vCPUs: production-like environments
vcpu_configs = "16 64" if "dev" in mode else "64"
native.genrule(
name = "generate-" + launch_measurements,
outs = [launch_measurements],
Expand All @@ -272,14 +279,16 @@ def icos_build(
cmd = r"""
source $(execpath """ + boot_args + """)
# Create GuestLaunchMeasurements JSON
(for cmdline in "$$BOOT_ARGS_A" "$$BOOT_ARGS_B"; do
hex=$$($(execpath //ic-os:sev-snp-measure) --mode snp --vcpus 64 --ovmf "$(execpath //ic-os/components/ovmf:ovmf_sev)" --vcpu-type=EPYC-v4 --append "$$cmdline" --initrd "$(location extracted_initrd.img)" --kernel "$(location extracted_vmlinuz)")
# Convert hex string to decimal list, e.g. "abcd" -> 171\\n205
measurement=$$(echo -n "$$hex" | fold -w2 | sed "s/^/0x/" | xargs printf "%d\n")
jq -na --arg cmd "$$cmdline" --arg m "$$measurement" '{
measurement: ($$m | split("\n") | map(tonumber)),
metadata: {kernel_cmdline: $$cmd}
}'
(for vcpus in """ + vcpu_configs + """; do
for cmdline in "$$BOOT_ARGS_A" "$$BOOT_ARGS_B"; do
hex=$$($(execpath //ic-os:sev-snp-measure) --mode snp --vcpus $$vcpus --ovmf "$(execpath //ic-os/components/ovmf:ovmf_sev)" --vcpu-type=EPYC-v4 --append "$$cmdline" --initrd "$(location extracted_initrd.img)" --kernel "$(location extracted_vmlinuz)")
# Convert hex string to decimal list, e.g. "abcd" -> 171\\n205
measurement=$$(echo -n "$$hex" | fold -w2 | sed "s/^/0x/" | xargs printf "%d\n")
jq -na --arg cmd "$$cmdline" --arg m "$$measurement" '{
measurement: ($$m | split("\n") | map(tonumber)),
metadata: {kernel_cmdline: $$cmd}
}'
done
done) | jq -sc "{guest_launch_measurements: .}" > $@
""",
)
Expand Down
Loading