Skip to content

fix: canonicalizes record and variant labels during subtype checking #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

fix: canonicalizes record and variant labels during subtype checking #1073

merged 2 commits into from
Jul 23, 2025

Conversation

@christoph-dfinity
Copy link
Contributor

@christoph-dfinity christoph-dfinity commented Jul 23, 2025

Fixes #1072

@christoph-dfinity christoph-dfinity requested a review from a team as a code owner July 23, 2025 10:38
@christoph-dfinity christoph-dfinity changed the title fix: canonicalizes record and variant labels durying subtype checking fix: canonicalizes record and variant labels during subtype checking Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/agent 47.86 KB (-0.01% 🔽)
@dfinity/assets 52.84 KB (-0.04% 🔽)
@dfinity/auth-client 19.38 KB (0%)
@dfinity/candid 13.22 KB (+0.07% 🔺)
@icp-sdk/core 91 B (0%)
@dfinity/identity 18.81 KB (0%)
@dfinity/identity-secp256k1 33.03 KB (0%)
@dfinity/principal 4.44 KB (0%)
@dfinity/use-auth-client 58.75 KB (-0.01% 🔽)

@christoph-dfinity christoph-dfinity force-pushed the christoph/record-subtyping-label-canon branch from c9338ab to 8972a51 Compare July 23, 2025 11:50
@ilbertt ilbertt merged commit b446a2f into main Jul 23, 2025
28 checks passed
@ilbertt ilbertt deleted the christoph/record-subtyping-label-canon branch July 23, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilbertt ilbertt ilbertt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Agent v3 fails on "ledger.query_blocks"

2 participants

@christoph-dfinity @ilbertt