Skip to content

Conversation

@ncpenke
Copy link
Contributor

@ncpenke ncpenke commented Nov 28, 2023

Description

Correctly honor disableIdle flag for the idle manager.

Fixes # (576)

#576

How Has This Been Tested?

Do not created the idle manager if disableIdle flag is passed on successful login. Tested this via usage in DSCVR.

Checklist:

  • My changes follow the guidelines in CONTRIBUTING.md.
  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ncpenke ncpenke requested a review from a team as a code owner November 28, 2023 02:37
@ghost ghost added the cla:agreed label Nov 28, 2023
@krpeacock
Copy link
Contributor

otherwise, looks good!

Co-authored-by: Kyle Peacock <kylpeacock@gmail.com>
@krpeacock krpeacock self-requested a review December 1, 2023 17:34
@krpeacock krpeacock enabled auto-merge (squash) December 1, 2023 17:36
@krpeacock krpeacock merged commit 40d9800 into dfinity:main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants