feat: adds fromPem method for identity-secp256k1 #816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
randombit
reviewed
Jan 4, 2024
Contributor
Author
|
@randombit got back to this today - should be more legible now. Thanks for your suggestions! |
ghost
approved these changes
Feb 16, 2024
krpeacock
commented
Feb 16, 2024
krpeacock
commented
Feb 16, 2024
|
LGTM |
hpeebles
pushed a commit
to hpeebles/agent-js
that referenced
this pull request
Mar 28, 2024
* feat: adds pemToSecretKey * feat: adds `fromPem` method for `identity-secp256k1` * wip * feat: check for ASN.1 OID before returning private key * rebuilding package-lock * increasing size limit * Update docs/generated/changelog.html * Update docs/generated/changelog.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a utility method to initialize a secp256k1 identity from a pem file.
Fixes SDK-1255
Fixes SDKTG-221
How Has This Been Tested?
Tested against a test identity exported from
dfxand compatible withdfxandkeysmithChecklist: