feat: introduces Observable Log for HttpAgent #842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 7, 2024
Contributor
size-limit report 📦
|
ghost
reviewed
Feb 7, 2024
| if (!this._rootKeyFetched) { | ||
| // Hex-encoded version of the replica root key | ||
| this.rootKey = ((await this.status()) as any).root_key; | ||
| this.rootKey = ((await this.status()) as JsonObject & { root_key: ArrayBuffer }).root_key; |
There was a problem hiding this comment.
What's going on here? This doesn't seem related to the description of the PR.
Contributor
Author
There was a problem hiding this comment.
ah, just cleaning up a linting warning in the file since I was touching it. Eventually I'd like to have no use of any in the codebase
ghost
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The agent currently outputs console logs, warnings, and errors to the console.
This introduces an Observer pattern, available as a public ["log"] attribute which returns a new type of AgentLog. Developers can add listeners to hook into the logs, and a new flag (
logToConsole) is provided, which will output these logs to the console.This is turned off by default.
How Has This Been Tested?
new unit tests
Checklist: