Skip to content

Drop internal cluster and ops-repo names from the staging runner comment - #105

Merged
aterga merged 1 commit into
mainfrom
claude/scrub-site-codes
Jul 29, 2026
Merged

Drop internal cluster and ops-repo names from the staging runner comment#105
aterga merged 1 commit into
mainfrom
claude/scrub-site-codes

Conversation

@aterga

@aterga aterga commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

The last infrastructure detail left in the tree. deploy.yml's ship_runs_on comment named the two specific clusters the dind-small pool runs on, its runner group, and the internal ops repository — none of which is needed to explain why the input is a bare scale-set name rather than a label list, which is the comment's actual job.

Flagged in pre-publication diligence alongside the issue/PR bodies. This is the tree half; the issue and PR bodies are being handled separately.

Related issues

#101. Completes the tree-side scrub started in #102 and #104.

Changes

  • deploy.yml: replaced the cluster/group/ops-repo naming with a generic description.

Kept the parts that carry information:

  • Why a label list matches nothing (ARC scale sets carry no default labels) — this is the mistake that left a deploy queued indefinitely, so it earns its place.
  • That the pool's pods reach the host over the VPN, confirmed by a deploy that passed the /version assertion.
  • That the pool spans more than one cluster and a pod can land on either, so the source address the host sees is not fixed. This is the load-bearing reason the port-22 rule can't be narrowed on a single observation (Narrow inbound SSH to the private range and delete the world-facing rule #91), and it survives without naming the sites.

Added a pointer to DEPLOY_HOST's description, since none of this holds if that names the public FQDN rather than the private address — staging was set that way, and its deploys were silently leaving over the internet.

Testing

Checklist

  • I have read the Contributing guidelines.
  • Docs (README / comments) updated for any user-visible change — this PR is the comment change.
  • No secrets, credentials, or internal-only information are included — it removes internal names rather than adding any.

Generated by Claude Code

The comment named the two specific clusters the dind-small pool runs on, its
runner group, and the internal ops repository. None of that is needed to explain
why the input is a bare scale-set name rather than a label list, which is the
comment's actual job, and this repo is heading for public visibility (#101).

Kept the parts that carry information: why a label list matches nothing, that
the pool's pods reach the host over the VPN, and that the pool spans more than
one cluster so the source address is not fixed — which is the reason the port-22
rule cannot be narrowed on a single observation.

Also points at DEPLOY_HOST's description, since none of this holds if that names
the public FQDN instead of the private address. Staging was set that way and its
deploys were leaving over the internet.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01R8ZshwKmjD5fZ4Hs9dS6zh
@aterga
aterga marked this pull request as ready for review July 29, 2026 17:18
@aterga
aterga requested review from a team and Copilot July 29, 2026 17:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes internal infrastructure identifiers from the staging deploy workflow’s ship_runs_on explanatory comment, while preserving the operational rationale for using a bare ARC scale-set name and for requiring DEPLOY_HOST to be privately reachable.

Changes:

  • Replaces the ship_runs_on comment text to omit specific cluster names, runner group, and internal ops repo references.
  • Keeps the key behavioral explanations: ARC scale sets lacking default labels, VPN/private reachability, and non-fixed source address due to multi-cluster scheduling.
  • Adds an explicit pointer that DEPLOY_HOST must be the host’s private address (with a reference to the secret’s description in deploy-native.yml).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aterga
aterga merged commit 24b44db into main Jul 29, 2026
2 checks passed
@aterga
aterga deleted the claude/scrub-site-codes branch July 29, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants