Drop internal cluster and ops-repo names from the staging runner comment - #105
Merged
Conversation
The comment named the two specific clusters the dind-small pool runs on, its runner group, and the internal ops repository. None of that is needed to explain why the input is a bare scale-set name rather than a label list, which is the comment's actual job, and this repo is heading for public visibility (#101). Kept the parts that carry information: why a label list matches nothing, that the pool's pods reach the host over the VPN, and that the pool spans more than one cluster so the source address is not fixed — which is the reason the port-22 rule cannot be narrowed on a single observation. Also points at DEPLOY_HOST's description, since none of this holds if that names the public FQDN instead of the private address. Staging was set that way and its deploys were leaving over the internet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R8ZshwKmjD5fZ4Hs9dS6zh
There was a problem hiding this comment.
Pull request overview
Removes internal infrastructure identifiers from the staging deploy workflow’s ship_runs_on explanatory comment, while preserving the operational rationale for using a bare ARC scale-set name and for requiring DEPLOY_HOST to be privately reachable.
Changes:
- Replaces the
ship_runs_oncomment text to omit specific cluster names, runner group, and internal ops repo references. - Keeps the key behavioral explanations: ARC scale sets lacking default labels, VPN/private reachability, and non-fixed source address due to multi-cluster scheduling.
- Adds an explicit pointer that
DEPLOY_HOSTmust be the host’s private address (with a reference to the secret’s description indeploy-native.yml).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sea-snake
approved these changes
Jul 29, 2026
aterga
added a commit
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last infrastructure detail left in the tree.
deploy.yml'sship_runs_oncomment named the two specific clusters thedind-smallpool runs on, its runner group, and the internal ops repository — none of which is needed to explain why the input is a bare scale-set name rather than a label list, which is the comment's actual job.Flagged in pre-publication diligence alongside the issue/PR bodies. This is the tree half; the issue and PR bodies are being handled separately.
Related issues
#101. Completes the tree-side scrub started in #102 and #104.
Changes
deploy.yml: replaced the cluster/group/ops-repo naming with a generic description.Kept the parts that carry information:
/versionassertion.Added a pointer to
DEPLOY_HOST's description, since none of this holds if that names the public FQDN rather than the private address — staging was set that way, and its deploys were silently leaving over the internet.Testing
deploy.ymlparses;ship_runs_onstill resolves to"dind-small".git grepfor the cluster names, runner group and ops-repo across the tree returns nothing, excluding base64 false positives inside the compiled asset bundle (src/assets/index.html, where those strings occur inside encoded image data).cargo/npm— comment-only change.Checklist
Generated by Claude Code