Split call_canister into canister_query and canister_update_call

[aterga]

Summary

Splits the dual-mode call_canister MCP tool into two focused tools — canister_update_call (writes) and canister_query (reads) — where canister_query accepts either a Candid query method or an OQL query. The standalone run_canister_oql_query tool is removed (its OQL logic now backs canister_query); get_canister_oql_schema remains its own tool.

Changes

• canister_update_call — state-changing update calls only. Drops the is_query flag; no OQL redirect (updates always pass through). Left permissive by design: the IC accepts a query method invoked via an update (a replicated/certified read, like dfx --update), so it is not blocked.
• canister_query — reads only, taking EITHER a Candid query method (+ args) OR an oql query (a JSON object string run against execute). Exactly one must be provided. The oql path requires derivation_origin (anonymous per-app reads stay disabled); the Candid method path may be anonymous and is redirected to oql on canisters that expose OQL. When the .did is readable and method is an update method, it fails fast with a pointer to canister_update_call (the replica rejects a query call to a non-query method); fail-open when the interface can't be read. Output carries a mode discriminator ("candid" / "oql").
• Removed run_canister_oql_query — its logic is now canister_query's oql branch (same query validation, empty/trap diagnosis, and paged table decoding).
• get_canister_oql_schema stays a standalone tool — the fixed icp_oql_guide → get_canister_oql_schema → canister_query (oql) flow is unchanged; its per-entity examples now reference canister_query. get_canister_candid remains a plain anonymous interface read.
• Updated the server instructions, tool descriptions, the OQL-redirect message, landing page, README, and OQL primer to the new names and flow.
• Tool count stays 26; the annotation and count tests are updated. New helper calls::is_query_method (treats query and composite_query as callable-as-query) backs the read/write guard.

Testing

• cargo build --all-targets
• cargo test --all-targets (125 passed, 0 failed)
• clippy: the new code introduces no new warnings (the pre-existing tree has drift in files not touched here).

Checklist

• I have read the Contributing guidelines.
• Docs (README / comments / landing page / primer) updated for the user-visible tool changes.
• No secrets, credentials, or internal-only information are included.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Hm7kgJhGH8j5F27gL5jWtb

[Copilot]

Pull request overview

This PR refactors the IC connector’s canister-call surface to cleanly separate reads from writes by splitting the former dual-mode call_canister tool into canister_query (read-only) and canister_update_call (state-changing), while folding OQL schema discovery into get_canister_candid and removing the standalone OQL query tool.

Changes:

• Introduces canister_query (Candid query method or OQL query) and canister_update_call (updates only), replacing the old dual-mode call_canister.
• Folds OQL schema retrieval into get_canister_candid (when derivation_origin is provided) and removes the separate OQL schema/query tools.
• Updates docs/UI copy (README, landing page, primers) and adjusts tool-count/annotation tests accordingly.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
static/oql-primer.md	Updates OQL workflow to use get_canister_candid (with origin) + canister_query (oql).
static/candid-textual-syntax.md	Updates references to new tool names for typed Candid encoding/decoding.
src/main.rs	Wires new tools, folds schema read into get_canister_candid, and implements canister_query/canister_update_call.
src/discover.rs	Updates open_app output docs to reference the new call tools.
src/calls.rs	Renames/reshapes argument/output types and updates OQL redirect/examples to the new flow.
src/assets/index.html	Updates landing-page tool list to the new tool names and usage.
README.md	Updates tool table, usage narrative, and curl examples to the new read/write split and OQL flow.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.