Fix computing winding in embolden - #135
Open
rhysd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #134
LayerMut::emboldencomputed the winding from all points in a layer as one polygon. With disconnected contours, this adds nonexistent edges between contours to the area calculation and can reverse the winding. As a result, synthetic bold could shrink some glyphs, such as Monaco'sireported in #134.This change computes the area for each contour separately and sums the results before determining the winding. Then the resulting global winding is used for all contours preserving the correct behavior for inner counter contours.
I verified this change with Monaco text on my app as follows. The existing tests and doc tests pass.