Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.0] Fix bug when exporting a predicate name to the schema. #3701

Merged
merged 2 commits into from Jul 23, 2019

Conversation

@martinmr
Copy link
Member

commented Jul 22, 2019

This change is fixing #3699 for the 1.0 branch. The logic in this branch
was slightly different. In this case, the brackets are only added if
there's a colon in the predicate name. This logic is also buggy as it
doesn't handle predicate names consisting of only numbers.

The fix is to add the brackets for every predicate name for consistency
and simplicity.


This change is Reviewable

This change is fixing #3699 for the 1.0 branch. The logic in this branch
was slightly different. In this case, the brackets are only added if
there's a colon in the predicate name. This logic is also buggy as it
doesn't handle predicate names consisting of only numbers.

The fix is to add the brackets for every predicate name for consistency
and simplicity.
@martinmr martinmr requested review from manishrjain and dgraph-io/team Jul 22, 2019
Copy link
Member

left a comment

:lgtm: Should this be brought into master?

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Member Author

left a comment

Yeah, there's already a PR for that: #3700

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit 7b94f15 into release/v1.0 Jul 23, 2019
4 of 5 checks passed
4 of 5 checks passed
Blockade (dgraph) TeamCity build started
Details
CI (dgraph) TeamCity build finished
Details
GolangCI No issues found!
Details
code-review/reviewable 2 files reviewed
Details
license/cla Contributor License Agreement is signed.
Details
@martinmr martinmr deleted the martinmr/export-pred-1.0 branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.