Fix: diff-hl-magit-post-refresh wrong file name#280
Merged
Conversation
`git diff-tree` is used and it generated relative file names. `buffer-file-name` generates full paths. Condition check always fails due to these being different.
Owner
|
Hi!
Maybe you wanted to use I suggest you also add a message in there printing the values on mismatch and post it the result here (with the fix not applied yet). To document the failure as it happens. |
- Use `file-relative-name` instead of `file-name-nondirectory` to properly match files in subdirectories against `modified-files`
Contributor
Author
|
Thank you. First, you are correct, I focused on top-level when testing. Fixed in 581c577. Second, when debugging the cond branch with: (or
(member file modified-files)
(ignore (message "FILE %s NOT IN %s" file modified-files)))one gets: hence the filename normalization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git diff-treeis used and generates relative (to top level) file names.buffer-file-namegenerates full paths.The following condition always fails due to the file names being different:
diff-hl/diff-hl.el
Line 1440 in 7d873b2
This fixes the refresh related to magit actions.