fix(ci): fix release workflow to wait specifically on validate check - #54
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe release workflow now gates publishing on the current commit’s Sequence diagram for release gating on validate checksequenceDiagram
participant Release as Release workflow
participant Checks as GitHub checks
participant Publisher as Publisher
Release->>Checks: wait-on-check(ref, check-name: validate)
loop Every 15 seconds
Checks-->>Release: validate status
end
alt validate conclusion is success or neutral
Release->>Publisher: Publish release
else validate is not allowed
Release-->>Publisher: Publishing blocked
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
@sourcery-ai review |
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/release.yml" line_range="55-61" />
<code_context>
- allowed-conclusions: success,neutral
- verbose: false
-
- - name: Wait on all tests
- uses: lewagon/wait-on-check-action@369769072fe522a3a8a85c03c96af1e5242a1994 # v1.9.1
- with:
- ref: ${{ github.sha }}
- running-workflow-name: 'release'
- repo-token: ${{ secrets.GITHUB_TOKEN }}
- wait-interval: 60
+ wait-interval: 15
allowed-conclusions: success,neutral
</code_context>
<issue_to_address>
**issue (bug_risk):** Removing the second `wait-on-check-action` step removes the only serialization against another running `release` workflow. Two pushes to `main` can therefore publish concurrently, causing overlapping tag/package updates and release failures or inconsistent publication state.
**Triggers:** When multiple commits reach `main` before the earlier release workflow finishes.
**Suggested fix:** Keep a wait or add a workflow-level concurrency group that serializes `release` runs while retaining the validate-check gate.
</issue_to_address>Sourcery assessment
Needs a human reviewer. 1 finding to address first, and the release job will now proceed after only the validate check, so another failing check could be skipped and a faulty release could be published. Reverting restores the old gate, but it cannot fully undo artifacts or versions already consumed by users.
Blocking findings: .github/workflows/release.yml:61
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Owner
Author
|
@sourcery-ai resolve |
Contributor
|
@sourcery-ai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure release workflow waits specifically for validate check to pass before publishing.
Summary by Sourcery
Make release publishing wait for a successful validate check and prevent concurrent releases.
Bug Fixes:
Enhancements:
CI: