fix: remove publish-breaking comment from package.json#47
Merged
Conversation
|
Deploy preview for dhis2-app-platform ready! Built with commit 3d3c43a |
Contributor
Author
|
Going to go ahead and merge this to kick off the deploy |
dhis2-bot
added a commit
that referenced
this pull request
Sep 17, 2019
## [1.3.1](v1.3.0...v1.3.1) (2019-09-17) ### Bug Fixes * remove publish-breaking comment from package.json ([#47](#47)) ([c45d97a](c45d97a))
Contributor
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishes have been silently failing (see dhis2/cli#131) since 1.2.0 because of the comment dependency in package.json. I moved the comment out of the dependencies map, which should work fine.