Merged
Conversation
varl
approved these changes
Sep 17, 2019
dhis2-bot
added a commit
that referenced
this pull request
Sep 17, 2019
## [2.2.2](v2.2.1...v2.2.2) (2019-09-17) ### Bug Fixes * don't swallow release command errors ([#131](#131)) ([8a09d32](8a09d32))
Contributor
|
🎉 This PR is included in version 2.2.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can cause release failures to silently succeed, which is bad news in CI deployment
I'm also worried that the git portion of semantic-release succeeded in pushing the version commit, even though the preceding npm publish step failed! That is not covered in this fix.