Merged
Conversation
git-subtree-dir: packages/core git-subtree-split: 18a77139405f204b74aaa9f814ebc17215856c5b
git-subtree-dir: packages/widgets git-subtree-split: 70b0228
The commits from the original branch were lost, so here are the breakings changes listed to make sure they show up in the changelog. BREAKING CHANGE: Rename the Constrictor component to Box, which is shorter and thus easier to type. This also expands the capabilities of Box to make it more Box-like. BREAKING CHANGE: Replace SwitchGroupField, RadioGroupField, CheckboxGroupField with ToggleGroupField. BREAKING CHANGE: Replace SwitchGroup, RadioGroup, CheckboxGroup with ToggleGroup. BREAKING CHANGE: The exports: colors, theme, layers, spacers, spacersNum, and elevations, have been moved from @dhis2/ui-core to @dhis2/ui-constants for better code reuse.
test(cypress): use should for assertions
COMMIT HISTORY: - refactor: introduce click based menu ui - refactor(menu): update component folder structure and replace files - fix(menu-item): solve prop-types error - docs(menu-item): add jsdocs - docs(menu-item): add demo story - fix(menu-item): correct demo link and spread props on li - fix(menu-divider): spread props, add jsdocs and demo story - fix(menu-section-header): tweak styles, add docs and story - fix: fix demo story links for menu-item/divider/sectionheader - fix(menu-list): tweak story and docs - docs(menu-item): add demo for toggle menu and custom icon color - docs(menu): tweak jsDocs and demo stories - docs(menu): add default dataTest value to jsDocs for various components - docs(menu-list): add demo for usage in a sidebar - fix(menu): only clone react elements, just render strings etc - fix(menu): stop spreading props and adding refs - test(menu): assert SubMenu toggling and rendering children - test(sub-menu): add e2e stories and cypress tests for positioning - test(menu-item): tweak e2e story and cypress tests - test(menu-item): wrap list-items in list to ensure valid HTML - test(menu-section-header): add e2e story and test for accepting children - chore(menu-section-header): remove unused import - fix: export all components and hooks that were introduced with the Menu - docs(menu-item): improve toggle-menu-item demo clarity - refactor(menu-item): integrate sub-menu into menu-item - test(menu): fix failing position cypress tests - test(menu-item): update failing cypress test for children to label - refactor(menu-section-header): change children to label like menu-item - fix(component-cover): align with Layer by removing pointerEvents - refactor: rename menu to flyout-menu and menu-list to menu - fix(menu-item): make sure menuItems for open sub-menus are active - refactor: move responsibility for dense and hideDivider on items to Menu BREAKING CHANGE: Fully overhauled Menu and related components: - MenuList was renamed to Menu - Menu was renamed to FlyoutMenu - The sub-menus now open on click instead of hover - We have introduced a dedicated `MenuDivider` and `MenuSectionHeader` - To create sub-menus, you can now add MenuItems directly under a parent MenuItem, no need to wrap them in a Menu/FlyoutMenu anymore
# [5.0.0-alpha.18](v5.0.0-alpha.17...v5.0.0-alpha.18) (2020-05-26) ### Code Refactoring * make menu click-based and reorganise related components ([a8b26a0](a8b26a0)) ### BREAKING CHANGES * Fully overhauled Menu and related components: - MenuList was renamed to Menu - Menu was renamed to FlyoutMenu - The sub-menus now open on click instead of hover - We have introduced a dedicated `MenuDivider` and `MenuSectionHeader` - To create sub-menus, you can now add MenuItems directly under a parent MenuItem, no need to wrap them in a Menu/FlyoutMenu anymore
a394432b chore(release): cut 4.21.1 [skip ci] ccd86bc2 fix: prevent icon from shrinking when label text overflows d3988811 chore(release): cut 4.21.0 [skip ci] fdabd2b8 docs: add info about virtual elements in popper and popover js-docs 3a065266 feat: add support for virtual elements in popper and popover a70782fb chore(release): cut 4.20.0 [skip ci] df11f3ca feat: let popper and popover accept react-refs or dom nodes directly git-subtree-dir: packages/core git-subtree-split: a394432b62e8485163fb7712e95f03480b79f2b3
Rename `onBackdropClick` to `onClickOutside` BREAKING CHANGE: The Popover's `onBackdropClick` prop has been renamed to `onClickOutside`
fix: fix improper merge resolution
# [5.0.0-alpha.19](v5.0.0-alpha.18...v5.0.0-alpha.19) (2020-05-26) ### Bug Fixes * **popover:** fix arrow rotation ([880395b](880395b)) * fix improper merge resolution ([0daeffb](0daeffb)) ### Code Refactoring * rename popover prop ([f7d5c20](f7d5c20)) ### BREAKING CHANGES * The Popover's `onBackdropClick` prop has been renamed to `onClickOutside`
This commit does several things: * Use strings as selected values * Use strings to store which options are highlighted * Removes jest test abstractions * Simplifies internal names * Replaces `common.js` files with files whose names match their content * Moves the Transfer component from `core` to `widgets` * Adds the `.js` extension to all import statements where applicable * Provides the correct `disabled` & `dataTest` props to the re-order up button's icon BREAKING CHANGE: The Transfer component now expects strings as selected values instead of option objects. BREAKING CHANGE: The Transfer component is now part of `widgets`
Fixes #50 This commit does several things: * Use strings as selected values * Use strings to store which options are highlighted * Removes jest test abstractions * Simplifies internal names * Replaces common.js files with files whose names match their content * Moves the Transfer component from core to widgets * Adds the .js extension to all import statements where applicable * Provides the correct disabled & dataTest props to the re-order up * button's icon BREAKING CHANGE: The Transfer component now expects options to be passed in as objects, not as children. Custom components can be provided via the optionComponent prop for all options or via the component property on an individual option. BREAKING CHANGE: The Transfer component now expects strings as selected values instead of option objects. BREAKING CHANGE: The Transfer component is now part of widgets
# [5.0.0-alpha.20](v5.0.0-alpha.19...v5.0.0-alpha.20) (2020-05-28) ### Code Refactoring * **transfer:** align with select & monorepo structure ([c15477d](c15477d)), closes [#50](#50) * **transfer:** align with select & monorepo structure ([d50f960](d50f960)) ### BREAKING CHANGES * **transfer:** The Transfer component now expects options to be passed in as objects, not as children. Custom components can be provided via the optionComponent prop for all options or via the component property on an individual option. * **transfer:** The Transfer component now expects strings as selected values instead of option objects. * **transfer:** The Transfer component is now part of widgets * **transfer:** The Transfer component now expects strings as selected values instead of option objects. * **transfer:** The Transfer component is now part of `widgets`
Fixes DHIS2-8525 Fixes DHIS2-8723
Upstream changes widgets
ghost
marked this pull request as ready for review
# [5.0.0-alpha.21](v5.0.0-alpha.20...v5.0.0-alpha.21) (2020-05-28) ### Bug Fixes * correctly select and use user locale and application title text ([1c9d055](1c9d055)) * escape regex special chars in search ([2f11c96](2f11c96))
docs(widgets): fix changelog manually
Contributor
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todo:
Jan-Gerke:
Hendrik:
Ismay:
Closes #41