Skip to content

refactor: split types.TaskLogEntry into domain & ui#177

Merged
dhth merged 1 commit into
mainfrom
split-task-log-entry-type-into-domain-and-ui
Jul 20, 2026
Merged

refactor: split types.TaskLogEntry into domain & ui#177
dhth merged 1 commit into
mainfrom
split-task-log-entry-type-into-domain-and-ui

Conversation

@dhth

@dhth dhth commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Move task log records and reporting projections into the domain package,
while keeping bubble tea list state and formatting in a UI-specific
adapter.

Persistence now works with domain models removing presentation
concerns from it.

Move task log records and reporting projections into the domain package,
while keeping bubble tea list state and formatting in a UI-specific
adapter.

Persistence now works with domain models removing presentation
concerns from it.
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ee23e61-fc6c-4992-a444-1325029baee0

📥 Commits

Reviewing files that changed from the base of the PR and between 3e82534 and c028241.

📒 Files selected for processing (18)
  • internal/domain/duration.go
  • internal/domain/duration_test.go
  • internal/domain/task_log.go
  • internal/persistence/queries.go
  • internal/persistence/queries_test.go
  • internal/types/date_helpers.go
  • internal/types/date_helpers_test.go
  • internal/types/types.go
  • internal/ui/cmds.go
  • internal/ui/handle.go
  • internal/ui/log.go
  • internal/ui/model.go
  • internal/ui/msgs.go
  • internal/ui/report.go
  • internal/ui/stats.go
  • internal/ui/task_log.go
  • internal/ui/task_log_test.go
  • internal/ui/view_test.go
💤 Files with no reviewable changes (3)
  • internal/types/date_helpers_test.go
  • internal/types/date_helpers.go
  • internal/types/types.go

📝 Walkthrough

Walkthrough

Task-log, active-task, and report models are defined in the domain package and removed from the types package. Persistence queries and fixtures are updated to scan and return domain models. UI messages, commands, handlers, calculations, reports, statistics, and log rendering now use those models. A taskLogListItem wrapper handles list presentation, comments, and relative time labels. Relative-time logic and its tests move from the types package to the UI package.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main refactor: moving TaskLogEntry from types into domain and UI-specific handling.
Description check ✅ Passed The description accurately describes moving task log models to domain and keeping list state/formatting in the UI layer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dhth
dhth merged commit 841156a into main Jul 20, 2026
13 checks passed
@dhth
dhth deleted the split-task-log-entry-type-into-domain-and-ui branch July 20, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant