Skip to content

fix(localization): DLT-3522 use unsupported locale in fallback tests#1356

Merged
Brad Paugh (braddialpad) merged 1 commit into
stagingfrom
fix/localization-test-ko-kr-stale
Jul 6, 2026
Merged

fix(localization): DLT-3522 use unsupported locale in fallback tests#1356
Brad Paugh (braddialpad) merged 1 commit into
stagingfrom
fix/localization-test-ko-kr-stale

Conversation

@braddialpad

Copy link
Copy Markdown
Contributor

ko-KR became a supported locale, which broke the tests that relied on it being unsupported to exercise the fallback path.

ko-KR became a supported locale, which broke the tests that relied on
it being unsupported to exercise the fallback path.
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: f7e3f147-b9ff-44bd-86f2-d4ac50d186cc

📥 Commits

Reviewing files that changed from the base of the PR and between 566d55d and 975d266.

📒 Files selected for processing (1)
  • packages/dialtone-vue/localization/index.test.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • dialpad/ios (manual)
  • dialpad/firespotter (manual)
  • dialpad/semantic-release-changelog-json (auto-detected)
  • dialpad/conventional-changelog-angular (auto-detected)

Updated localization fallback tests to use a different unsupported locale (tr-TR) instead of ko-KR, since ko-KR is now supported. The fallback assertions still verify behavior when the stored locale is unsupported and when the navigator language should be used.

Overall Judgement: ✅ Ready to merge — The change is narrowly scoped to test fixtures and preserves the intended fallback coverage.

Walkthrough

This PR updates test stubs in the DialtoneLocalization test suite, changing the simulated unsupported locale from ko-KR to tr-TR for window.localStorage and navigator.language in getPreferredLocale fallback test cases.

Changes

Localization Test Update

Layer / File(s) Summary
Update stubbed unsupported locale
packages/dialtone-vue/localization/index.test.js
Changed stubbed locale value from ko-KR to tr-TR in tests covering fallback to en-US and fallback to navigator language when the stored locale is unsupported.

Possibly related PRs

  • dialpad/dialtone#1350: Also updates unsupported-locale fallback test stubs in the same test file.
  • dialpad/dialtone#1352: Updates the same fallback tests in response to ko-KR being added to allowedLocales, which is likely why ko-KR is no longer a valid unsupported-locale test value here.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/localization-test-ko-kr-stale

Comment @coderabbitai help to get the list of available commands.

@braddialpad
Brad Paugh (braddialpad) merged commit e1cd4db into staging Jul 6, 2026
12 checks passed
@braddialpad
Brad Paugh (braddialpad) deleted the fix/localization-test-ko-kr-stale branch July 6, 2026 21:10
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Jul 7, 2026
# [3.223.0](dialtone-vue/v3.222.3...dialtone-vue/v3.223.0) (2026-07-07)

### Bug Fixes

* **Combobox:** DLT-3520 prevent list element error during popover transition ([#1351](#1351)) ([aeda99d](aeda99d))
* **Localization:** DLT-3522 use unsupported locale in fallback tests ([#1356](#1356)) ([e1cd4db](e1cd4db))
* **Localization:** UC-27003 fall back to a supported locale instead of crashing ([#1350](#1350)) ([17d93a3](17d93a3))

### Features

* **Localization:** DLT-3522 add ko-KR and sv-SE as supported locales ([#1352](#1352)) ([566d55d](566d55d))
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Jul 7, 2026
# [9.188.0](dialtone/v9.187.3...dialtone/v9.188.0) (2026-07-07)

### Bug Fixes

* **Combobox:** DLT-3520 prevent list element error during popover transition ([#1351](#1351)) ([aeda99d](aeda99d))
* **Localization:** DLT-3522 use unsupported locale in fallback tests ([#1356](#1356)) ([e1cd4db](e1cd4db))
* **Localization:** UC-27003 fall back to a supported locale instead of crashing ([#1350](#1350)) ([17d93a3](17d93a3))

### Features

* **Icons:** DP-192348 add compass icons ([#1354](#1354)) ([92a547a](92a547a))
* **Localization:** DLT-3522 add ko-KR and sv-SE as supported locales ([#1352](#1352)) ([566d55d](566d55d))
Brad Paugh (braddialpad) pushed a commit that referenced this pull request Jul 14, 2026
# [10.0.0-next.3](dialtone/v10.0.0-next.2...dialtone/v10.0.0-next.3) (2026-07-14)

### Bug Fixes

* **Combobox:** DLT-3520 prevent list element error during popover transition ([#1351](#1351)) ([aeda99d](aeda99d))
* **Dt Popover:** DLT-3519 added boundary prop ([#1348](#1348)) ([6ef6957](6ef6957))
* **Editor:** DP-194072 tiptap warning duplicate extension names found ['textStyle'] ([#1346](#1346)) ([4ac8871](4ac8871))
* **Localization:** DLT-3522 use unsupported locale in fallback tests ([#1356](#1356)) ([e1cd4db](e1cd4db))
* **Localization:** UC-27003 fall back to a supported locale instead of crashing ([#1350](#1350)) ([17d93a3](17d93a3))
* **Scrollbar:** DLT-3494 register --os-scroll-percent globally for shadow DOM support ([#1359](#1359)) ([346b2dc](346b2dc))

### Documentation

* NO-JIRA regenerate component preview images ([dc08180](dc08180))

### Features

* **Icons:** DP-192348 add compass icons ([#1354](#1354)) ([92a547a](92a547a))
* **Localization:** DLT-3522 add ko-KR and sv-SE as supported locales ([#1352](#1352)) ([566d55d](566d55d))
* NO-JIRA add dot export to dialtone package ([#1366](#1366)) ([86c1bbc](86c1bbc))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant