fix(popover): DLT-3550 guard focusFirstElementIfNeeded against unset content ref

[Brad Paugh (braddialpad)]

Summary

• Fixes a null-pointer crash in focusFirstElementIfNeeded when a delayed after-enter transition callback fires against a stale/unset $refs.content (e.g. main thread blocked during the enter transition).
• returnFirstEl(this.$refs.content?.$el) can resolve to null; the fallback .focus() call is now optionally chained, matching the existing null-safety pattern used elsewhere in the same file (focusInitialElement, focusInitialElementById).
• Adds a regression test that reproduces the stale-ref scenario for the "no focusable elements, showCloseButton false" fallback branch.

Jira: DLT-3550 (https://dialpad.atlassian.net/browse/DLT-3550)

Test plan

• pnpm nx run dialtone-vue:test - Popover.test.js: 59 passed, 2 skipped
• New test reproduces the crash without the fix and passes with the fix applied

[github-actions]

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Workspace UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 97cb2199-033d-4edb-9760-720a312a4742

📥 Commits

Reviewing files that changed from the base of the PR and between 217f154 and f50b69e.

📒 Files selected for processing (2)

• packages/dialtone-vue/components/Popover/Popover.test.js
• packages/dialtone-vue/components/Popover/Popover.vue

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• dialpad/ios (manual)
• dialpad/firespotter (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Updated focusFirstElementIfNeeded to avoid a null-pointer crash when $refs.content is stale or unset. Added a regression test for popovers without focusable content or a close button.

Overall Judgement: ✅ Ready to merge — The fix is narrowly scoped and tested with 59 passing tests and 2 skipped tests.

Walkthrough

The popover fallback focus path now tolerates an unavailable content reference. A regression test covers delayed focus execution after the reference becomes unset.

Changes

Popover focus safety

Layer / File(s)	Summary
Guard fallback focus and test stale references packages/dialtone-vue/components/Popover/Popover.vue, packages/dialtone-vue/components/Popover/Popover.test.js	The fallback focus operation uses optional chaining. The test verifies that delayed focus does not throw when the content reference is unavailable.

Suggested reviewers: francisrupert, iropolo, ninarepetto, belumontoya, paulojreis-dialpad

Merge Risk: ⚪ Minimal · up to f50b6

This change prevents a popover focus callback from throwing when its content is unavailable and includes regression coverage for the affected fallback path. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docs-To-Code Alignment	✅ Passed	PASS. The net PR diff changes only packages/dialtone-vue/components/Popover/Popover.vue and its regression test; it does not change CLI commands, configuration options, public props, events, or sign…
Disabled Test Tracking	✅ Passed	The PR does not neutralize any test. The Popover commit adds a normal describe block and a normal it regression test, with no skip, ignore, disable, expected-failure, exclusion, or rename change. …

Full details: Docs-To-Code Alignment

Explanation

PASS. The net PR diff changes only packages/dialtone-vue/components/Popover/Popover.vue and its regression test; it does not change CLI commands, configuration options, public props, events, or signatures. The code change only prevents .focus() from throwing when an internal stale $refs.content is absent. Existing Popover documentation still accurately describes the normal focus behavior, and this edge-case crash guard does not make that documentation stale.

Full details: Disabled Test Tracking

Explanation

The PR does not neutralize any test. The Popover commit adds a normal describe block and a normal it regression test, with no skip, ignore, disable, expected-failure, exclusion, or rename change. The existing it.skip and describe.skip markers are identical before and after the commit.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/dlt-3550-popover-null-focus-crash

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✔️ Deploy previews ready!
😎 Dialtone documentation preview: https://dialtone.dialpad.com/deploy-previews/pr-1407/
😎 Dialtone-vue preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-1407/