Skip to content

fix(toast): NO-JIRA put z-index on wrapper#677

Merged
Brad Paugh (braddialpad) merged 2 commits intostagingfrom
toast-wrapper-zindex
Mar 25, 2025
Merged

fix(toast): NO-JIRA put z-index on wrapper#677
Brad Paugh (braddialpad) merged 2 commits intostagingfrom
toast-wrapper-zindex

Conversation

@braddialpad
Copy link
Copy Markdown
Contributor

@braddialpad Brad Paugh (braddialpad) commented Mar 21, 2025

fix(toast): put z-index on wrapper

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Description

move z-index to wrapper

💡 Context

If the z-index is not on the outer container, it's pretty useless.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.
  • I have added all relevant documentation.
  • I have considered the performance impact of my change.

@braddialpad Brad Paugh (braddialpad) changed the title fix(toast): put z-index on wrapper fix(toast): NO-JIRA put z-index on wrapper Mar 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2025

Please add either the visual-test-ready or no-visual-test label to this PR depending on whether you want to run visual tests or not.
It is recommended to run visual tests if your PR changes any UI. ‼️

@braddialpad Brad Paugh (braddialpad) merged commit beca85a into staging Mar 25, 2025
6 of 7 checks passed
@braddialpad Brad Paugh (braddialpad) deleted the toast-wrapper-zindex branch March 25, 2025 16:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2025

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-677/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-677/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-677/

Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone-css/v8.50.3
6c1b7b7 
## [8.50.3](dialtone-css/v8.50.2...dialtone-css/v8.50.3) (2025-03-27)

### Bug Fixes

* **Toast:** NO-JIRA put z-index on wrapper ([#677](#677)) ([beca85a](beca85a))
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.106.1
61ed5ce 
## [9.106.1](dialtone/v9.106.0...dialtone/v9.106.1) (2025-03-27)

### Bug Fixes

* **Callbar Button With Dropdown:** DLT-2440 add missing slot prop close ([#682](#682)) ([3034563](3034563))
* **Toast:** NO-JIRA put z-index on wrapper ([#677](#677)) ([beca85a](beca85a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliodialpad Julio Ortega (juliodialpad) Awaiting requested review from juliodialpad

@iropolo Ignacio Ropolo (iropolo) Awaiting requested review from iropolo iropolo is a code owner

@francisrupert Francis Rupert (francisrupert) Awaiting requested review from francisrupert francisrupert is a code owner

1 more reviewer

@ninamarina Nina Repetto (ninamarina) ninamarina approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@braddialpad Brad Paugh (braddialpad)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@braddialpad @ninamarina