Skip to content

fix(callbar-button-with-dropdown): DLT-2440 add missing slot prop close#682

Merged
Julio Ortega (juliodialpad) merged 1 commit intostagingfrom
DLT-2440_callbar-button-with-dropdown-missing-slot-scope
Mar 25, 2025
Merged

fix(callbar-button-with-dropdown): DLT-2440 add missing slot prop close#682
Julio Ortega (juliodialpad) merged 1 commit intostagingfrom
DLT-2440_callbar-button-with-dropdown-missing-slot-scope

Conversation

@juliodialpad
Copy link
Copy Markdown
Contributor

@juliodialpad Julio Ortega (juliodialpad) commented Mar 25, 2025

Add missing close slot prop

Obligatory GIF (super important!)

Obligatory GIF

🛠️ Type Of Change

These types will increment the version number on release:

  • Fix

📖 Jira Ticket

https://dialpad.atlassian.net/browse/DLT-2440

📖 Description

  • Added missing close slot prop
  • Synced Vue 2 and Vue 3 version of the component

💡 Context

  • A bug was reported that the callbar button with dropdown was not closing as expected.

📝 Checklist

For all PRs:

  • I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
  • I have reviewed my changes.

For all Vue changes:

  • I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script

@juliodialpad
add missing slot prop close
0151f2f 
Signed-off-by: Julio Ortega <julio.ortega@dialpad.com>
@juliodialpad Julio Ortega (juliodialpad) added the visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests label Mar 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2025

✔️ Deploy previews ready!
😎 Dialtone preview: https://dialtone.dialpad.com/deploy-previews/pr-682/
😎 Dialtone-vue 2 preview: https://dialtone.dialpad.com/vue/deploy-previews/pr-682/
😎 Dialtone-vue 3 the preview: https://dialtone.dialpad.com/vue3/deploy-previews/pr-682/

braddialpad
Brad Paugh (braddialpad) approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@braddialpad Brad Paugh (braddialpad) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@juliodialpad Julio Ortega (juliodialpad) merged commit 3034563 into staging Mar 25, 2025
11 of 14 checks passed
@juliodialpad Julio Ortega (juliodialpad) deleted the DLT-2440_callbar-button-with-dropdown-missing-slot-scope branch March 25, 2025 21:19
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue2/v2.179.1
24c6abe 
## [2.179.1](dialtone-vue2/v2.179.0...dialtone-vue2/v2.179.1) (2025-03-27)

### Bug Fixes

* **Callbar Button With Dropdown:** DLT-2440 add missing slot prop close ([#682](#682)) ([3034563](3034563))
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone-vue3/v3.172.1
d377924 
## [3.172.1](dialtone-vue3/v3.172.0...dialtone-vue3/v3.172.1) (2025-03-27)

### Bug Fixes

* **Callbar Button With Dropdown:** DLT-2440 add missing slot prop close ([#682](#682)) ([3034563](3034563))
Julio Ortega (juliodialpad) pushed a commit that referenced this pull request Apr 3, 2025
@semantic-release-bot
chore(release): NO-JIRA dialtone/v9.106.1
61ed5ce 
## [9.106.1](dialtone/v9.106.0...dialtone/v9.106.1) (2025-03-27)

### Bug Fixes

* **Callbar Button With Dropdown:** DLT-2440 add missing slot prop close ([#682](#682)) ([3034563](3034563))
* **Toast:** NO-JIRA put z-index on wrapper ([#677](#677)) ([beca85a](beca85a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braddialpad Brad Paugh (braddialpad) braddialpad approved these changes

@iropolo Ignacio Ropolo (iropolo) Awaiting requested review from iropolo iropolo is a code owner

@francisrupert Francis Rupert (francisrupert) Awaiting requested review from francisrupert francisrupert is a code owner

@ninamarina Nina Repetto (ninamarina) Awaiting requested review from ninamarina

Assignees

@juliodialpad Julio Ortega (juliodialpad)

Labels

visual-test-ready Add this tag when the PR is ready for visual test, to trigger GHA visual tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliodialpad @braddialpad