Skip to content

Console: sidebar docstrings say five view links while it renders six #53

Description

@dichovsky

Two stale five-view counts in the navigation rail's own comments, both contradicted by the code and tests immediately below them:

  • web/components/sidebar.tsx:2 — "brand, the five view links with their live badges". The same file's ViewId union at web/components/sidebar.tsx:9 has six members (now | overview | agents | tasks | messages | operations), and the NAV array at sidebar.tsx:41-101 has six matching entries.
  • web/components/sidebar.test.tsx:2 — "Sidebar tests: the five nav links…", while the test it describes at sidebar.test.tsx:39 is named renders the six views and marks the active one.

The count went stale when ADR-0017 added the Now view; the sibling docstring in web/app.tsx:3 was updated to "six views (Now, Overview, Agents, Tasks, Messages, Operations)" and these two were not.

Found while verifying #27, which enumerates the same stale count in four docs. These are source comments rather than docs, so they are tracked separately and were deliberately left out of #27's docs-only change (PR #57).

Unrelated and correct, for whoever picks this up: the "five" in web/components/tasks-view.tsx:2 and tasks-view.test.tsx:2,79 refers to the five Task status columns, not views — leave those alone.

Impact: the navigation rail's header comment contradicts the type declared four lines below it, and its test file's header contradicts its own assertion — the first thing a contributor reads about the component is wrong in both places.

Acceptance: both docstrings name six view links, matching ViewId at sidebar.tsx:9, web/app.tsx:3, and ADR-0017.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions