Fix HiDPI mode filtering for portrait displays - #24
Merged
Conversation
bang0223
approved these changes
Aug 5, 2026
bang0223
approved these changes
Aug 5, 2026
Owner
|
Hardware-verified on a physically rotated Dell U2412M (1200x1920 portrait) alongside an AOC Q27G3XMN (2560x1440 landscape) and the built-in display:
Thanks for the fix! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Rotated portrait displays could lose their usable HiDPI modes because the native aspect ratio was inferred from the largest backing buffer, which could belong to a landscape HiDPI mode. The resolution menu also used landscape-only minimum dimensions.
This change:
make testentry point.How tested
make test— 3 tests passedmake compile./scripts/release.sh v0.0.0-ci— universal arm64 + x86_64 DMG builtChecklist
./dev.sh, or./scripts/release.sh v0.0.0-cifor the full release build)Crisp/Resources/Localizable.xcstringsfor any new user-facing strings (N/A: no new strings)