Avoid preset reads during SwiftUI layout - #87
Merged
Conversation
Owner
|
Verified on my M4 Max MacBook Pro on 26.5.1: the Preset list on the built-in XDR panel renders all eleven entries from the cached snapshot, switching to HDR Video moves the checkmark and the row subtitle, and switching back works. CI, lint and compile are green, merging. One honest note: I couldn't reproduce the nested run loop. A run-loop observer around the MonitorPanel getters ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DisplayProfileController.reload().DisplayPresetViewfrom the cached controller state and update that state after a successful selection.Split from #86 at reviewer request so the crash fix can land independently.
Testing
make check