fix(layout): parse inherited rgba/rgb SVG stroke and fill colors#3434
Open
Manitej66 wants to merge 1 commit into
Open
fix(layout): parse inherited rgba/rgb SVG stroke and fill colors#3434Manitej66 wants to merge 1 commit into
Manitej66 wants to merge 1 commit into
Conversation
Inherited stroke/fill properties from parent `<Svg>` elements with functional color syntax (`rgba()`, `rgb()`) were not being parsed to hex before reaching the PDF renderer. This happened because `inheritProps` ran after `resolveChildren(container)` in the compose chain, so children were parsed before receiving the parent's raw color strings — leaving untransformed `rgba(...)` values that PDFKit cannot render. Swap the order so `inheritProps` propagates raw color strings to children first, then `resolveChildren` parses them through `transformColorSafe` during child resolution. Hex and named colors (already pass-through) are unaffected.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix inherited SVG
rgba()/rgb()stroke and fill renderingSummary
Fixes an issue where inherited SVG
strokeandfillproperties using functional color syntax (rgba(),rgb()) were not rendered correctly in@react-pdf/renderer.Previously, inherited color values from parent
<Svg>elements reached child nodes before color normalization occurred, leaving rawrgba(...)strings untransformed when passed to PDFKit.Broken example
The following SVG failed to render strokes correctly:
Observed behavior:
<Path>strokes were not renderedstroke="rgba(...)"directly onto each<Path>workedExample workaround:
or:
Root cause
The compose chain executed:
This caused child nodes to be resolved before inheriting parent paint properties. As a result:
rgba(...)/rgb(...)values bypassedtransformColorSafeHex and named colors appeared unaffected because they already passed through unchanged.
Fix
Swapped the compose order so inherited props are applied before child resolution:
This ensures inherited paint properties are normalized during child resolution through
transformColorSafe.Result
Inherited SVG paint properties now render correctly for:
rgba()rgb()Example now working correctly:
Before:

After:

Notes
strokeandfillproperties.