Fixup coding standard formatting and spelling #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thk123
suggested changes
Jun 23, 2017
CODING_STANDARD.md
Outdated
| - Separate basic words by `_` | ||
| - Avoid abbreviations (e.g. prefer `symbol_table` to `st`). | ||
| - User defined type identifiers have to be terminated by `t`. Moreover, before | ||
| `t` may not be `t`. |
Contributor
There was a problem hiding this comment.
Should be:
Moreover, before t may not be _
CODING_STANDARD.md
Outdated
| source_file2.cpp \ | ||
| # Empty last line | ||
| ``` | ||
| - This ensures the Makefiles can be easily merged. |
Contributor
There was a problem hiding this comment.
I don't think this should be a bullet point
Contributor
Author
|
Fixed |
thk123
approved these changes
Jun 23, 2017
peterschrammel
approved these changes
Jun 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to markdown to improve readability. Also fixes a few typos. Implements the changes in #1049.