Introduce complex_imag_exprt and complex_real_exprt #2916
Conversation
danpoe
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
smowton,
tautschnig and
thk123
as code owners
src/util/std_expr.h
Outdated
| } | ||
|
|
||
|
|
||
| /// \brief Real part |
There was a problem hiding this comment.
part ... of what? (I'd say "Real part of the expression describing a complex number.")
src/util/std_expr.h
Outdated
| PRECONDITION(expr.id() == ID_complex_real); | ||
| DATA_INVARIANT( | ||
| expr.operands().size() == 1, | ||
| "Real part retrieval operation must have one operand"); |
There was a problem hiding this comment.
Use lowercase for error messages (applies across this PR).
src/util/std_expr.h
Outdated
|
|
||
|
|
||
| /// \brief Imaginary part | ||
| class complex_imag_exprt:public unary_exprt |
There was a problem hiding this comment.
I think clang-format wants spaces around :
danpoe
force-pushed
the
refactor/introduce-imag-and-real-expressions
branch
2 times, most recently
from
bb6ad6d to
899fe03
Compare
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: c76d96f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84129475
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: bb6ad6d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84132032
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 899fe03).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84142660
chrisr-diffblue
left a comment
chrisr-diffblue
left a comment
There was a problem hiding this comment.
LGTM - this seems a lot cleaner.
4 participants
No description provided.